-
Notifications
You must be signed in to change notification settings - Fork 778
Add cookie assertions framework #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dmurvihill
wants to merge
1
commit into
forwardemail:master
Choose a base branch
from
dmurvihill:cookie-assertions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you fix the merge conflict? |
Add a convenient workflow for running assertions on cookie headers
returned by the server. This code is largely copied from Gregory
Langais' package `expect-cookie` (MIT License).
Example usage:
```js
const request = require('supertest');
const cookies = request.cookies;
request(app)
.get('/users')
.expect('Content-Type', /json/)
.expect('Content-Length', '15')
.expect(200)
// assert 'alpha' cookie is set with domain, path, and httpOnly options
.expect(cookies.set({ name: 'alpha', options: ['domain', 'path', 'httponly'] }))
// assert 'bravo' cookie is NOT set
.expect(cookies.not('set', { name: 'bravo' }))
.end(function(err, res) {
if (err) {
throw err;
}
});
```
Supports:
- `.set` - Assert that cookie and options are set.
- `.reset` - Assert that cookie is set and was already set (in request
headers).
- `.new` - Assert that cookie is set and was NOT
already set (NOT in request headers).
- `.renew` - Assert that cookie is set with a strictly greater `expires`
or `max-age` than the given value.
- `.contain` - Assert that cookie is set with value and contains
options.
- `.not` - Call any cookies assertion method with "assert true" modifier
set to `false`.
feat(cookies): add cookie assertions
Add a convenient workflow for running assertions on cookie headers
returned by the server. This code is largely copied from Gregory
Langais' package `expect-cookies` (MIT License).
Example usage:
```js
const request = require('supertest');
const cookies = request.cookies;
request(app)
.get('/users')
.expect('Content-Type', /json/)
.expect('Content-Length', '15')
.expect(200)
// assert 'alpha' cookie is set with domain, path, and httpOnly options
.expect(cookies.set({ name: 'alpha', options: ['domain', 'path', 'httponly'] }))
// assert 'bravo' cookie is NOT set
.expect(cookies.not('set', { name: 'bravo' }))
.end(function(err, res) {
if (err) {
throw err;
}
});
```
Supports:
- `.set` - Assert that cookie and options are set.
- `.reset` - Assert that cookie is set and was already set (in request
headers).
- `.new` - Assert that cookie is set and was NOT
already set (NOT in request headers).
- `.renew` - Assert that cookie is set with a strictly greater `expires`
or `max-age` than the given value.
- `.contain` - Assert that cookie is set with value and contains
options.
- `.not` - Call any cookies assertion method with "assert true" modifier
set to `false`.
366c7ef to
4f89680
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Author
|
Fixed. Sorry, not sure how that happened. |
Author
|
Everything look ok now? |
A1exKH
approved these changes
Sep 25, 2025
A1exKH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a convenient workflow for running assertions on cookie headers returned by the server. This code is largely copied from Gregory Langlais' package
expect-cookies(MIT License).Implements #855.
Example usage:
Supports:
.set- Assert that cookie and options are set..reset- Assert that cookie is set and was already set (in request headers)..new- Assert that cookie is set and was NOT already set (NOT in request headers)..renew- Assert that cookie is set with a strictly greaterexpiresormax-agethan the given value..contain- Assert that cookie is set with value and contains options..not- Call any cookies assertion method with "assert true" modifier set tofalse.Checklist