Feature/Moving main url out of strings.xml#27
Merged
maestromac merged 4 commits intoforem:masterfrom May 20, 2019
Merged
Conversation
|
|
Glennmen
reviewed
May 4, 2019
| release { | ||
| minifyEnabled false | ||
| proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro' | ||
| resValue("string", "baseUrl", "\"https://dev.to\"") |
Contributor
Author
There was a problem hiding this comment.
The resValue has been added so that when in future the baseUrl needs to be referred from resource files, it is already available to do so.
| minifyEnabled false | ||
| proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro' | ||
| resValue("string", "baseUrl", "\"https://dev.to\"") | ||
| buildConfigField("String", "baseUrl", "\"https://dev.to\"") |
There was a problem hiding this comment.
I think this can be made cleaner with:
Suggested change
| buildConfigField("String", "baseUrl", "\"https://dev.to\"") | |
| buildConfigField("String", "baseUrl", '"https://dev.to"') |
maestromac
approved these changes
May 20, 2019
Contributor
maestromac
left a comment
There was a problem hiding this comment.
LGTM!
@Glennmen thanks for your input here. Those are valid points but since there are no code here that's a deal breaker I'm going to merge it first. You are welcome to submit follow-up PR though!
Contributor
Author
|
@Glennmen @maestromac if the suggested changes are required then I can submit another PR for those, but I do suggest that we keep the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
As per the discussion in issue #20 I have moved the main-url from string-resource to a build-config field in
build.gradle.Related Tickets & Documents
Issue #20