Skip to content

[RFC-0012] Introduce Artifact SDK#1020

Merged
stefanprodan merged 6 commits intomainfrom
sdk
Sep 4, 2025
Merged

[RFC-0012] Introduce Artifact SDK#1020
stefanprodan merged 6 commits intomainfrom
sdk

Conversation

@stefanprodan
Copy link
Copy Markdown
Member

This PR extracts the storage functionality from source-controller and adds a server component for hosting artifacts.

Changes to upstream:

  • Add common configuration and controller flags for artifact serving and storage
  • Add graceful shutdown to the artifact server
  • Improve storage test coverage

Part of: fluxcd/flux2#5504

ℹ️ For now, the fluxcd/pkg/artifact module is intended for use in source-controller.

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
The config pkg contains flags and options for artifact file server and storage configuration

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan requested a review from a team as a code owner September 4, 2025 11:36
Copy link
Copy Markdown
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

just a small nit

Comment thread artifact/digest/digest.go Outdated
Port the multi-digest functionality from source-controller

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Port the storage functionality from source-controller and improve tests coverage

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Implement artifact server designed to serve artifacts over HTTP with graceful shutdown support compatible with controller-runtime

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit 8c611af into main Sep 4, 2025
11 checks passed
@stefanprodan stefanprodan deleted the sdk branch September 4, 2025 12:24
@stefanprodan stefanprodan added the area/artifact Artifact SDK related issues and pull requests label Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/artifact Artifact SDK related issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants