fix(sensors_plus)!: Use magnetometer instead of deviceMotion#2250
Merged
vbuberen merged 1 commit intofluttercommunity:mainfrom Nov 23, 2023
tlserver:magnetometer
Merged
fix(sensors_plus)!: Use magnetometer instead of deviceMotion#2250vbuberen merged 1 commit intofluttercommunity:mainfrom tlserver:magnetometer
vbuberen merged 1 commit intofluttercommunity:mainfrom
tlserver:magnetometer
Conversation
7 tasks
Collaborator
|
This PR also need a fix for formatting. Please fix it first. |
Contributor
Author
|
Formatting issues fixed, please review when you have time~ |
vbuberen
requested changes
Nov 22, 2023
Collaborator
vbuberen
left a comment
There was a problem hiding this comment.
Could you fix conflicts?
BREAKING CHANGE: different behaviour
Contributor
Author
Collaborator
I won't release plugin update till all your PRs on this topic merged as well as till documentation is updated, so no worries here. |
vbuberen
approved these changes
Nov 23, 2023
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As #2248 said:
So this PR use magnetometer instead of deviceMotion. but this is a BREAKING CHANGE!!
Related Issues
Require #2248
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).