Add EditableText scroll into view breaking change note#8916
Add EditableText scroll into view breaking change note#8916sfshaza2 merged 10 commits intoflutter:mainfrom tgucio:scroll-into-view
Conversation
sfshaza2
left a comment
There was a problem hiding this comment.
A few tweaks and a question.
| To date, `EditableText` has used multiple mechanisms ensuring the selection | ||
| extent or caret is scrolled into view on updates. |
There was a problem hiding this comment.
Not sure what you mean by "on updates".
| To date, `EditableText` has used multiple mechanisms ensuring the selection | |
| extent or caret is scrolled into view on updates. | |
| Previously, `EditableText` used multiple mechanisms to determine the | |
| extent of the selection, or to ensure that the caret is scrolled into view. |
There was a problem hiding this comment.
Thanks for the edits. Yes, this is a bit convoluted: what I meant were the mechanisms used on scrolling into view (which happens on user updates) to determine either of:
- selection extent (non-collapsed selection)
- caret position (collapsed selection).
Let me reword as:
Previously, upon scrolling into view to show user updates,
EditableTextused multiple mechanisms to determine the extent of the selection or the caret location.
| By removing the `Editable.onCaretChanged` callback, `EditableText` will always | ||
| use the most up to selection extent location when scrolling to show it. | ||
| Specifically this results in improved scroll into view behavior after | ||
| changing selection from collapsed to non-collapsed via | ||
| `userUpdateTextEditingValue()`. |
There was a problem hiding this comment.
What does "use the most up to selection extent location" mean?
I've made some tweaks, but would do more once I understand this phrase.
| By removing the `Editable.onCaretChanged` callback, `EditableText` will always | |
| use the most up to selection extent location when scrolling to show it. | |
| Specifically this results in improved scroll into view behavior after | |
| changing selection from collapsed to non-collapsed via | |
| `userUpdateTextEditingValue()`. | |
| By removing the `Editable.onCaretChanged` callback, `EditableText` will always | |
| use the most up to selection extent location when scrolling to show it. | |
| Specifically, this improves scroll into view behavior after | |
| changing selection from collapsed to non-collapsed using | |
| `userUpdateTextEditingValue()`. |
There was a problem hiding this comment.
The underlying issue had to do with using multiple sources of truth where one wasn't necessarily up to date (could be one frame behind).
What is clearly missing is "date" as in "up to date" :). Correcting this.
| ## Timeline | ||
|
|
||
| Landed in version: 3.12.0-4.0.pre<br> | ||
| In stable release: 3.13.0 |
There was a problem hiding this comment.
The 3.13 release? It's probably best to just say "TBD" for now.
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
|
@sfshaza2 wondering if you could take another look so we can merge framework's PR 109114? Thanks! |
Breaking change note for flutter/flutter#109114
Presubmit checklist