Add notice on v1 embedding removal to 3.29.0 breaking changes#11749
Merged
parlough merged 13 commits intoflutter:mainfrom Feb 28, 2025
Merged
Add notice on v1 embedding removal to 3.29.0 breaking changes#11749parlough merged 13 commits intoflutter:mainfrom
parlough merged 13 commits intoflutter:mainfrom
Conversation
loic-sharma
reviewed
Feb 27, 2025
reidbaker
requested changes
Feb 27, 2025
|
|
||
| If your project references any of the above classes, consult the following list for instructions on migration. | ||
|
|
||
| * `io.flutter.app.FlutterActivity` was replaced with `io.flutter.embedding.android.FlutterActivity`. |
Contributor
There was a problem hiding this comment.
Consider making this a table instead of text.
added 2 commits
February 27, 2025 12:04
reidbaker
approved these changes
Feb 27, 2025
Collaborator
|
Visit the preview URL for this PR (updated for commit 1d82ef2): https://flutter-docs-prod--pr11749-v1-embedding-27nmggcc.web.app |
loic-sharma
reviewed
Feb 27, 2025
loic-sharma
reviewed
Feb 27, 2025
loic-sharma
reviewed
Feb 27, 2025
parlough
approved these changes
Feb 28, 2025
Member
parlough
left a comment
There was a problem hiding this comment.
Thanks for adding this notice/guide! It'll definitely be helpful :)
I made a few minor formatting and copy changes, but looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
The deletion of the v1 embedding (flutter/engine#51229) should have had an associated breaking changes notice. Unfortunately this was missed, under the assumption that a flutter tool check would have caught references to the v1 embedding in an earlier release, and provided upgrade instructions.
Issues fixed by this PR (if any):
flutter/flutter#164024
PRs or commits this PR depends on (if any):
Presubmit checklist