This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_admob]Destroy adView Before contentView Checking#849
Closed
karmactonics wants to merge 1 commit intoflutter:masterfrom
Closed
[firebase_admob]Destroy adView Before contentView Checking#849karmactonics wants to merge 1 commit intoflutter:masterfrom
karmactonics wants to merge 1 commit intoflutter:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
|
bump |
collinjackson
added a commit
to collinjackson/flutterfire
that referenced
this pull request
Aug 26, 2019
Contributor
|
Migrated to firebase/flutterfire#2 |
collinjackson
added a commit
to firebase/flutterfire
that referenced
this pull request
Aug 30, 2019
[firebase_admob]Destroy adView Before contentView Checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When displaying an advertisement using firebase_admob, advertisement may remain displayed if transitioning from a screen displaying a banner advertisement to a screen not displaying.
Specifically, if you call "dispose ()" immediately after "load ()" and "show ()" the ad, it will return by checking contentView and the ad may not be destroyed.
This can be reproduced by creating a screen using Tabbar, tapping Tabbar and quickly transitioning the screen.
Therefore, in order to solve this phenomenon, I send a pull request.
Even if this fix is not approved, I'd like to solve this problem somehow.