This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter_android] Fixes crash when the Java InstanceManager was used after plugin was removed from engine#6943
Merged
auto-submit[bot] merged 7 commits intoflutter:mainfrom Jan 14, 2023
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
InstanceManager was used after plugin was removed from engine.
InstanceManager was used after plugin was removed from engine.InstanceManager was used after plugin was removed from engine
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2023
…ceManager` was used after plugin was removed from engine (flutter/plugins#6943)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2023
…ceManager` was used after plugin was removed from engine (flutter/plugins#6943)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 17, 2023
…ceManager` was used after plugin was removed from engine (flutter/plugins#6943)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 17, 2023
* d607cd910 Roll Flutter from 0d91c03 to 2201698 (28 revisions) (flutter/plugins#6953) * e2d174ca1 [tool] Check for search paths in Swift plugins (flutter/plugins#6954) * f80aabf03 [shared_preferences] Revert recent iOS example changes (flutter/plugins#6955) * f36fa6407 [android_webview_controller] Fixes bug where an `AndroidController` couldn't be reused (flutter/plugins#6910) * b751ff166 [webview_flutter_android] Fixes crash when the Java `InstanceManager` was used after plugin was removed from engine (flutter/plugins#6943) * 1efd51837 Roll Flutter from 2201698 to 68dd63d (9 revisions) (flutter/plugins#6956) * eda98cddb Roll Flutter from 68dd63d to 1220245 (4 revisions) (flutter/plugins#6957) * 4e5cf2d2d Roll Flutter from 1220245 to 8c2fdb8 (2 revisions) (flutter/plugins#6979)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#118624) * d607cd910 Roll Flutter from 0d91c03 to 2201698 (28 revisions) (flutter/plugins#6953) * e2d174ca1 [tool] Check for search paths in Swift plugins (flutter/plugins#6954) * f80aabf03 [shared_preferences] Revert recent iOS example changes (flutter/plugins#6955) * f36fa6407 [android_webview_controller] Fixes bug where an `AndroidController` couldn't be reused (flutter/plugins#6910) * b751ff166 [webview_flutter_android] Fixes crash when the Java `InstanceManager` was used after plugin was removed from engine (flutter/plugins#6943) * 1efd51837 Roll Flutter from 2201698 to 68dd63d (9 revisions) (flutter/plugins#6956) * eda98cddb Roll Flutter from 68dd63d to 1220245 (4 revisions) (flutter/plugins#6957) * 4e5cf2d2d Roll Flutter from 1220245 to 8c2fdb8 (2 revisions) (flutter/plugins#6979)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
… was used after plugin was removed from engine (flutter#6943) * dont throw errors on all instance manager methods * tests * version bump * change to logging a warning and ignore calls in other methods * the * documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that the methods no longer throw and crash the app if the manager is closed. They now just ignore the call and log a warning. Similar to how
WebView.destroyhandles usage after it is called.An alternative solution was to have
if(instanceManager.isClosed()) return;added to every Flutter API method, but this seemed to easy to forget to add to new additions.Fixes flutter/flutter#118199
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.