This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter_wkwebview] Fix potential timeouts in the integration tests#6869
Closed
bparrishMines wants to merge 2 commits intoflutter:mainfrom
Closed
[webview_flutter_wkwebview] Fix potential timeouts in the integration tests#6869bparrishMines wants to merge 2 commits intoflutter:mainfrom
bparrishMines wants to merge 2 commits intoflutter:mainfrom
Conversation
cyanglaz
reviewed
Dec 22, 2022
Contributor
cyanglaz
left a comment
There was a problem hiding this comment.
Code LGTM, CI is failing on XCUITests and seems unrelated:
Test Case '-[FLTWebViewUITests testTransparentBackground]' started.
t = 0.00s Start Test at 2022-12-20 10:24:22.169
t = 0.06s Set Up
t = 0.06s Open dev.flutter.plugins.webviewFlutterExample
t = 0.08s Launch dev.flutter.plugins.webviewFlutterExample
t = 0.29s Setting up automation session
t = 2.48s Wait for dev.flutter.plugins.webviewFlutterExample to idle
t = 4.01s Waiting 30.0s for "Show menu" Button to exist
t = 5.09s Checking `Expect predicate `exists == 1` for object "Show menu" Button`
t = 5.09s Checking existence of `"Show menu" Button`
t = 5.16s Tap "Show menu" Button
t = 5.16s Wait for dev.flutter.plugins.webviewFlutterExample to idle
t = 6.38s Find the "Show menu" Button
t = 6.41s Check for interrupting elements affecting "Show menu" Button
t = 6.44s Synthesize event
t = 6.85s Wait for dev.flutter.plugins.webviewFlutterExample to idle
t = 6.89s Waiting 30.0s for "Transparent background example" Button to exist
t = 7.92s Checking `Expect predicate `exists == 1` for object "Transparent background example" Button`
t = 7.92s Checking existence of `"Transparent background example" Button`
t = 7.96s Tap "Transparent background example" Button
t = 7.96s Wait for dev.flutter.plugins.webviewFlutterExample to idle
t = 7.98s Find the "Transparent background example" Button
t = 8.04s Check for interrupting elements affecting "Transparent background example" Button
t = 8.08s Synthesize event
t = 8.39s Wait for dev.flutter.plugins.webviewFlutterExample to idle
t = 8.44s Waiting 30.0s for "Transparent background test" StaticText to exist
t = 9.49s Checking `Expect predicate `exists == 1` for object "Transparent background test" StaticText`
t = 9.49s Checking existence of `"Transparent background test" StaticText`
/Volumes/Work/s/w/ir/x/w/plugins/packages/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerUITests/FLTWebViewUITests.m:85: error: -[FLTWebViewUITests testTransparentBackground] : ((CGColorEqualToColor(redColor, centerColor.CGColor)) is true) failed
Contributor
|
@bparrishMines Does this just need the latest |
Contributor
Author
|
Possibly. I wanted to explore the flake that @cyanglaz pointed out. But it could end up just being fixed after pulling from main. I'll try. |
Contributor
Author
|
Fixed in #6996 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of fix for
webview_flutterandwebview_Flutter_android: #6857Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.