[google_maps_flutter_web] Allow marker position updates#6753
[google_maps_flutter_web] Allow marker position updates#6753AsturaPhoenix wants to merge 1 commit intoflutter:mainfrom
Conversation
|
Thanks for the contribution! Could you merge in the latest main? This is branched from a version older than the last update to our infrastructure tokens, so most of the CI is unable to run. |
b2bb539 to
fad76e5
Compare
|
Done; please let me know if further action is required from me. I'm not familiar with these tests, but the failing test looks like it can't find the compass button on iOS. I don't have an iOS test setup yet, and this change was limited to the web plugin. |
Unconditionally convert the current marker position in `convert.dart:_markerOptionsFromMarker`, to allow for position updates. Also adds position changes to `marker_test.dart/MarkerController/update` and `markers_test.dart/MarkersController/changeMarkers`. The `MarkersController` case is fixed by this patch.
fad76e5 to
03c3c54
Compare
|
Looks like that test may have been reverted. Rebasing and rerunning. |
|
@ditman Ping on this review. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages. Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord. Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state! |
Unconditionally convert the current marker position in
convert.dart:_markerOptionsFromMarker, to allow for position updates.Also adds position changes to
marker_test.dart/MarkerController/updateandmarkers_test.dart/MarkersController/changeMarkers. TheMarkersControllercase is fixed by this patch.Issue: flutter/flutter#83467
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.