This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter_platform_interface] - Added limitsNavigationsToAppBoundDomains to WebSettings#4464
Closed
GauteHaugen wants to merge 4 commits intoflutter:masterfrom
GauteHaugen:webview_flutter_platform_interface
Closed
[webview_flutter_platform_interface] - Added limitsNavigationsToAppBoundDomains to WebSettings#4464GauteHaugen wants to merge 4 commits intoflutter:masterfrom GauteHaugen:webview_flutter_platform_interface
GauteHaugen wants to merge 4 commits intoflutter:masterfrom
GauteHaugen:webview_flutter_platform_interface
Conversation
11 tasks
added 4 commits
November 3, 2021 16:19
Contributor
|
Sorry for the churn, but based on your latest update in the main PR I don't think we have a clear picture of what the implementation should actually look like after all, so I'm going to close this for now; I think there's a good chance we'll end up wanting something different at this layer by the time that discussion resolves. Once we have an end-to-end design that works for the creation-time-only version, we can re-split a platform interface PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added limitsNavigationsToAppBoundDomains that is an optional setting for iOS 14+.
PR is the first PR replacement of #4339
List which issues are fixed by this PR. You must list at least one issue.
(flutter/issues/89530)
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.