This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] add support for content-uri based videos (android only)#4261
Closed
byunme wants to merge 2 commits intoflutter:masterfrom
Closed
[video_player] add support for content-uri based videos (android only)#4261byunme wants to merge 2 commits intoflutter:masterfrom
byunme wants to merge 2 commits intoflutter:masterfrom
Conversation
| @@ -1,5 +1,6 @@ | |||
| ## NEXT | |||
| ## 2.1.15 | |||
Contributor
There was a problem hiding this comment.
Nit: a new feature should bump the minor version rather than the patch.
Contributor
|
Thanks for the submission! @blasten This looks pretty straightforward; can you take a look? |
blasten
approved these changes
Aug 26, 2021
blasten
reviewed
Aug 26, 2021
Comment on lines
+36
to
+41
|
|
||
| # FOR TESTING ONLY. DO NOT MERGE. | ||
| dependency_overrides: | ||
| video_player_platform_interface: | ||
| path: | ||
| ../../video_player_platform_interface No newline at end of file |
Contributor
There was a problem hiding this comment.
It'll be removed once the PR is split (https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins). It can't accidentally be left because this fails publishable.
Contributor
|
@byunme Are you planning on splitting this into the component PRs now so that we can move forward with landing this? |
11 tasks
Contributor
Author
|
@stuartmorgan Sorry for the delay, I've split off the interface part here: #4307 |
11 tasks
Member
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
This PR adds playback from contentUri support for the video_player plugin (Android only).
The current Android implementation uses ExoPlayer, which already supports playback from uri, so this change is just to surface contentUri as a valid video datasource on the dart side.
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#88130
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.