This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera_web] Add createCamera implementation#4182
Merged
ditman merged 4 commits intoflutter:masterfrom Jul 22, 2021
VeryGoodOpenSource:feat/camera-web-create-camera
Merged
[camera_web] Add createCamera implementation#4182ditman merged 4 commits intoflutter:masterfrom VeryGoodOpenSource:feat/camera-web-create-camera
createCamera implementation#4182ditman merged 4 commits intoflutter:masterfrom
VeryGoodOpenSource:feat/camera-web-create-camera
Conversation
Contributor
Author
ditman
approved these changes
Jul 22, 2021
Member
ditman
left a comment
There was a problem hiding this comment.
LGTM! I'll revert the platform_interface change for now!
packages/camera/camera_platform_interface/lib/src/types/resolution_preset.dart
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /// Maps the given [resolutionPreset] to [Size]. | ||
| Size mapResolutionPresetToSize(ResolutionPreset resolutionPreset) { |
Member
There was a problem hiding this comment.
Should this take in to account the screen orientation? I don't remember if we had to flip the w/h on the photobooth when the app was rotated? Do you remember @felangel?
Contributor
Author
There was a problem hiding this comment.
Hmm, I can see that photobooth records the screen orientation when the photo is being captured. Then, the photo is displayed inside the AspectRatio widget with an aspect ratio based on that orientation but not sure if that has anything to do with flipping the w/h. 🤔
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
createCameraimplementation of the camera platform interface.mapFacingModeToCameraTypetoCameraSettings.mapResolutionPresetToSizetoCameraSettings.createCameraimplementation.availableCamerasto extract the camera type.CameraOptions.Part of flutter/flutter#45297.
Pre-launch Checklist
dart format.)[shared_preferences]///).