Fix webview_flutter Android integration tests and add Espresso by bparrishMines · Pull Request #4147 · flutter/plugins

bparrishMines · 2021-07-08T18:49:35Z

Integration tests weren't running since they were in the androidTestDebug folder and not a androidTest folder. This changes the folder name and fix the tests that weren't running.

Part of: flutter/flutter#83358

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…t=/Users/bmparr/Development/plugins/../test_driver/webview_flutter_test.dart

bparrishMines · 2021-07-18T00:18:14Z

packages/webview_flutter/example/android/app/src/main/AndroidManifest.xml

  <application
    android:icon="@mipmap/ic_launcher"
    android:label="webview_flutter_example"
+    android:usesCleartextTraffic="true"


For the espresso package

bparrishMines · 2021-07-18T00:24:56Z

packages/webview_flutter/example/integration_test/webview_flutter_test.dart

      expect(fullScreen, _webviewBool(false));
    });

+    // allowsInlineMediaPlayback is a noop on Android, so it is skipped.


https://github.com/flutter/plugins/blob/master/packages/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java#L397

This test fails when running on Android, but it doesn't seem like there is anything we can do since a flag like this isn't supported on Android. At least according to the comment.

bparrishMines · 2021-07-18T02:19:45Z

packages/webview_flutter/example/integration_test/webview_flutter_test.dart

    final WebViewController controller = await controllerCompleter.future;
-    await controller.evaluateJavascript('window.open("about:blank", "_blank")');
+    await controller
+        .evaluateJavascript('window.open("https://flutter.dev/", "_blank")');


This test would stall on Android. For some reason, Android has different behavior when a window.open is called with a url with https:// vs not. It loads normally when using a URL with https://, but appends the url to the current url when it doesnt. (e.g. https://flutter.dev/ turns into https://flutter.dev/about:blank)

bparrishMines · 2021-07-18T02:23:52Z

packages/webview_flutter/example/integration_test/webview_flutter_test.dart

  });

  testWidgets(
    'can open new window and go back',


Fixed the weird bug where pageLoaded.complete() was called in the callback multiple times. From the Dart side, this caused a silent error and prevented the rest of the method calls from going through.

packages/webview_flutter/example/android/app/build.gradle

...e/android/app/src/androidTest/java/io/flutter/plugins/webviewflutterexample/WebViewTest.java

bparrishMines · 2021-07-19T18:03:05Z

packages/webview_flutter/example/android/app/src/debug/AndroidManifest.xml

@@ -0,0 +1,21 @@
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"


This file is needed to use WebViewTestActivity.

blasten · 2021-07-19T21:09:11Z

packages/webview_flutter/example/android/app/build.gradle


 dependencies {
    testImplementation 'junit:junit:4.12'
+    testImplementation "com.google.truth:truth:1.0"


this doesn't seem used, is it?

stuartmorgan-g

LGTM!

bparrishMines · 2021-07-20T21:25:42Z

@stuartmorgan @blasten I think this PR is ready to go, but the tests seem to be pretty flaky. Is it alright to submit this if the integration tests require 2-3 runs to pass? Should I investigate more about why they are flaky or could I just skip the flaky ones for now?

stuartmorgan-g · 2021-07-21T19:02:20Z

@stuartmorgan @blasten I think this PR is ready to go, but the tests seem to be pretty flaky. Is it alright to submit this if the integration tests require 2-3 runs to pass? Should I investigate more about why they are flaky or could I just skip the flaky ones for now?

Let's skip the flaky tests, with a bug filed to follow up (please CC me, and mark it team)

stuartmorgan-g · 2021-07-22T15:48:52Z

With #4172 landed, you'll need to have this PR remove webview_flutter from the exclude list (currently in .cirrus.yml, but #4183 moves it if that lands before this does).

bparrishMines · 2021-07-22T21:22:59Z

@stuartmorgan @blasten I skipped the flaky tests and added a link to flutter/flutter#86757. PTAL and I'll merge

stuartmorgan-g

Wow, that's a lot of flakes :(

But LGTM

flutter/plugins#4147)

blasten · 2021-07-28T23:38:02Z

packages/webview_flutter/webview_flutter/example/android/app/src/debug/AndroidManifest.xml

@@ -0,0 +1,17 @@
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    package="io.flutter.plugins.webviewflutterexample">
+    <!-- Flutter needs it to communicate with the running application


"needs internet permission to"

blasten · 2021-07-28T23:40:08Z

.../android/app/src/main/java/io/flutter/plugins/webviewflutterexample/WebViewTestActivity.java

+import io.flutter.embedding.android.FlutterActivity;
+import io.flutter.embedding.engine.FlutterEngine;
+
+// Extends FlutterActivity to make the FlutterEngine accessible for testing.


what about: Makes the FlutterEngine accessible for testing.

…er#4147)

lets see if integration tests run

18e6d22

google-cla bot added the cla: yes label Jul 8, 2021

github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-android labels Jul 8, 2021

bparrishMines added 6 commits July 12, 2021 15:55

change folder name

2025b84

create a running test with ./gradlew app:connectedAndroidTest -Ptarge…

ddf5d91

…t=/Users/bmparr/Development/plugins/../test_driver/webview_flutter_test.dart

see if tests run on ci?.

562cc4d

fix a few tests

cad641b

try get all tests passing

b94cfbb

fluttertestrunner and placeholder test

744c395

bparrishMines commented Jul 18, 2021

View reviewed changes

formatting

6d9f282

bparrishMines commented Jul 18, 2021

View reviewed changes

fix blank test, formatting, license

e5ea80c

bparrishMines commented Jul 18, 2021

View reviewed changes

undo formatting change and remove navigation delegate

2489c44

bparrishMines changed the title ~~lets see if integration tests run~~ Fix webview_flutter Android integration tests Jul 18, 2021

bparrishMines changed the title ~~Fix webview_flutter Android integration tests~~ Fix webview_flutter Android integration tests and add Expresso Jul 18, 2021

bparrishMines requested review from blasten and stuartmorgan-g July 18, 2021 02:45

stuartmorgan-g changed the title ~~Fix webview_flutter Android integration tests and add Expresso~~ Fix webview_flutter Android integration tests and add Espresso Jul 19, 2021

stuartmorgan-g reviewed Jul 19, 2021

View reviewed changes

packages/webview_flutter/example/android/app/build.gradle Outdated Show resolved Hide resolved

...e/android/app/src/androidTest/java/io/flutter/plugins/webviewflutterexample/WebViewTest.java Outdated Show resolved Hide resolved

bparrishMines added 3 commits July 19, 2021 10:59

Improve example test and version bump test dependencies

76d612e

remove assertequals

dc6be9a

small format changes

8713690

bparrishMines commented Jul 19, 2021

View reviewed changes

license

648e94c

blasten reviewed Jul 19, 2021

View reviewed changes

remove truth dependency, change core dep and follow example

3619762

stuartmorgan-g approved these changes Jul 20, 2021

View reviewed changes

bparrishMines added 3 commits July 20, 2021 11:51

Merge branch 'master' of github.com:flutter/plugins into androidTest

f624087

readd analysisoptions

a10bfde

remove top line

42b7238

e-adrien mentioned this pull request Jul 20, 2021

[webview_flutter] Add an option to set the background color of the webview #3431

Merged

empty commit to check for flakes

927b9fe

bparrishMines added 3 commits July 22, 2021 10:54

skip tests

089fa76

Merge branch 'master' of github.com:flutter/plugins into androidTest

77b45f1

remove webview_flutter

7e73bb1

Merge branch 'master' of github.com:flutter/plugins into androidTest

79d82c4

stuartmorgan-g approved these changes Jul 23, 2021

View reviewed changes

Merge branch 'master' into androidTest

d34c705

bparrishMines added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jul 26, 2021

fluttergithubbot merged commit 1dce6ab into flutter:master Jul 26, 2021

bparrishMines deleted the androidTest branch July 26, 2021 18:35

bparrishMines mentioned this pull request Jul 26, 2021

[webview_flutter] Add file chooser on Android #3225

Closed

13 tasks

engine-flutter-autoroll mentioned this pull request Jul 27, 2021

Roll Plugins from 027db9039c03 to 530a18705f74 (21 revisions) flutter/flutter#87080

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021

1dce6ab Fix webview_flutter Android integration tests and add Espresso (

a2db51d

flutter/plugins#4147)

engine-flutter-autoroll mentioned this pull request Jul 27, 2021

Roll Plugins from 027db9039c03 to 5f42c6920cc6 (22 revisions) flutter/flutter#87088

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021

1dce6ab Fix webview_flutter Android integration tests and add Espresso (

f9dc0a9

flutter/plugins#4147)

engine-flutter-autoroll mentioned this pull request Jul 27, 2021

Roll Plugins from 758c55e42064 to 2727efc5ba3a (12 revisions) flutter/flutter#87131

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021

1dce6ab Fix webview_flutter Android integration tests and add Espresso (

d210274

flutter/plugins#4147)

blasten reviewed Jul 28, 2021

View reviewed changes

fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021

Fix webview_flutter Android integration tests and add Espresso (flutt…

80dd258

…er#4147)

amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021

Fix webview_flutter Android integration tests and add Espresso (flutt…

26ca6a1

…er#4147)

		@@ -0,0 +1,21 @@
		<manifest xmlns:android="http://schemas.android.com/apk/res/android"

Conversation

bparrishMines commented Jul 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

bparrishMines commented Jul 20, 2021

Uh oh!

stuartmorgan-g commented Jul 21, 2021

Uh oh!

stuartmorgan-g commented Jul 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bparrishMines commented Jul 22, 2021

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bparrishMines commented Jul 8, 2021 •

edited

Loading

stuartmorgan-g commented Jul 22, 2021 •

edited

Loading