This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Removed redundant request for camera permission#4001
Merged
mvanbeusekom merged 3 commits intoflutter:masterfrom Jun 2, 2021
Merged
Conversation
Updated pubspec version and changelog.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 2, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
…er#4001) * Removed all permissions and updated unit tests * Updated pubspec version and changelog. Updated pubspec version and changelog. * Update version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was pointed out that since the image picker plugin relies on the
ACTION_VIDEO_CAPTUREandACTION_IMAGE_CAPTUREintents for accessing the camera, it is not required to request the camera permission.This PR removes the request for camera permissions.
The permission requests for reading and writing external storage were already removed, and since after that the camera permission was the only remaining permission being requested by the plugin, I took out everything related to permissions as well.
Relevant issue:
Pre-launch Checklist
dart format. See plugin_tool format)[shared_preferences]///).