Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[scripts/tool] use 'flutter pub get' for both dart and flutter packages#3973

Merged
stuartmorgan-g merged 3 commits intoflutter:masterfrom
devoncarew:normalize_pub_commands
May 27, 2021
Merged

[scripts/tool] use 'flutter pub get' for both dart and flutter packages#3973
stuartmorgan-g merged 3 commits intoflutter:masterfrom
devoncarew:normalize_pub_commands

Conversation

@devoncarew
Copy link
Contributor

@devoncarew devoncarew commented May 24, 2021 •
edited
Loading

This PR switches the CI to calling flutter pub get for both Dart and Flutter packages (previously, we'd call dart pub get for non-Flutter packages). This normalizes the output in CIs a bit - dart pub get lists all the packages and versions that were resolved, while flutter pub get just emits one line of stdout. See https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8846322703236505168/+/u/analyze_flutter_plugins/stdout for an example of the existing CI output.

This work is generally in service to dart-lang/sdk#45873 (which itself is part of dart-lang/sdk#46075).

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • [-] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • [-] I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • [-] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@devoncarew devoncarew requested a review from stuartmorgan-g May 24, 2021 22:23
@google-cla google-cla bot added the cla: yes label May 24, 2021
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented May 24, 2021

Isn't this less efficient? Presumably the Flutter version is a superset of the Dart version.

@devoncarew
Copy link
Contributor Author

devoncarew commented May 25, 2021

Isn't this less efficient? Presumably the Flutter version is a superset of the Dart version.

I don't think this will have any significant impact on time - flutter packages get is just a thin wrapper on dart pub get.

stuartmorgan-g
stuartmorgan-g approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devoncarew devoncarew added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 25, 2021
@fluttergithubbot
Copy link

fluttergithubbot commented May 25, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows Plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 25, 2021
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented May 25, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows Plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

Follow flutter/flutter#83349

@christopherfujino
Copy link

christopherfujino commented May 26, 2021

I landed https://flutter-review.googlesource.com/c/recipes/+/13920 and re-triggered Windows Plugins, hopefully it goes green.

@christopherfujino
Copy link

christopherfujino commented May 26, 2021

Ok, since the recipe change didn't work, I reverted the tools change and re-triggered "Windows Plugins" again.

@stuartmorgan-g stuartmorgan-g merged commit 30add64 into flutter:master May 27, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 27, 2021
@engine-flutter-autoroll
30add64 use 'flutter pub get' for both dart and flutter packages (flu…
03f9126 
…tter/plugins#3973)
yasargil added a commit to yasargil/plugins that referenced this pull request Jun 2, 2021
@yasargil
Merge branch 'master' into gmain
9d6ff71 
* master: (131 commits)
  [in_app_purchase] fix "autoConsume" param in "buyConsumable" (flutter#3957)
  [video_player_web] fix: set autoplay to false during initialization (flutter#3985)
  [multiple_web] Adapt web PlatformView widgets to work slotted. (flutter#3964)
  [url_launcher] Add iOS unit and UI tests (flutter#3987)
  [image_picker] Change storage location for camera captures to internal cache on Android, to comply with new Google Play storage requirements.  (flutter#3956)
  [script/tool] Use 'dart pub' instead of deprecated 'pub' (flutter#3991)
  [video_player] Add iOS unit and UI tests (flutter#3986)
  Add pubspec convention checks (flutter#3984)
  Enable pubspec dependency sorting lint (flutter#3983)
  [image_picker] Migrate maven repo from jcenter to mavenCentral (flutter#3915)
  [video_player] Update README.md (flutter#3975)
  [script/tool] speed up the pub get portion of the analyze command (flutter#3982)
  Revert commit e742a7b (flutter#3976)
  Added support to request list of purchases (flutter#3944)
  [google_maps_flutter] Add iOS unit and UI tests (flutter#3978)
  Added Windows to the description (flutter#3936)
  use 'flutter pub get' for both dart and flutter packages (flutter#3973)
  [camera] android-rework part 3: Android exposure related features (flutter#3797)
  Remove exoplayer workaround from everything but video_player (flutter#3980)
  Allow reverts when checking versions (flutter#3981)
  ...
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@devoncarew @fotiDim
use 'flutter pub get' for both dart and flutter packages (flutter#3973)
46a93fd
@stuartmorgan-g stuartmorgan-g mentioned this pull request Aug 19, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devoncarew @stuartmorgan-g @fluttergithubbot @christopherfujino