Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Image picker fix alert#3881

Merged
fluttergithubbot merged 10 commits intoflutter:masterfrom
Baseflow:image_picker_fix_alert
May 17, 2021
Merged

[image_picker] Image picker fix alert#3881
fluttergithubbot merged 10 commits intoflutter:masterfrom
Baseflow:image_picker_fix_alert

Conversation

@ydag
Copy link
Contributor

@ydag ydag commented May 12, 2021 •
edited
Loading

Since UIAlertView is deprecated I implemented UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead. I also made some small fixes.

Related issues :

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

ydag added 4 commits May 11, 2021 20:58
@ydag
Add UIAlertController implementation
e13dc30 
Since UIAlertView is deprecated I implemented UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead.
@ydag
Fix to dispatch everything at once
1117af5
@ydag
Remove unnecessary condition
5178493
@ydag
Add the description into CHANGELOG file
6d7c1a4
@ydag ydag requested a review from cyanglaz as a code owner May 12, 2021 14:39
@google-cla google-cla bot added the cla: yes label May 12, 2021
@ydag ydag mentioned this pull request May 12, 2021
Closed
@stuartmorgan-g stuartmorgan-g self-requested a review May 12, 2021 17:12
ydag added 2 commits May 17, 2021 09:45
@ydag
Merge branch 'master' into image_picker_fix_alert
5be7968 
# Conflicts:
#	packages/image_picker/image_picker/CHANGELOG.md
#	packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m
@ydag
Updated pubspec.yaml and CHANGELOG.md files
40decd7
@ydag ydag force-pushed the image_picker_fix_alert branch from f421063 to 40decd7 Compare May 17, 2021 07:46
@ydag ydag mentioned this pull request May 17, 2021
Merged
11 tasks
mvanbeusekom
mvanbeusekom suggested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question regarding a double if (granted) { test in the code, and I feel the version number should not be updated as a feature but rather a patch as the functionality doesn't change but instead just use a different SDK internally.

packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m Outdated
Comment on lines 221 to 222
if (granted) {
if (granted) {
Copy link
Contributor

@mvanbeusekom mvanbeusekom May 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the double if (granted) { check?

Copy link
Contributor Author

@ydag ydag May 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is fixed.

packages/image_picker/image_picker/pubspec.yaml Outdated
library, and taking new pictures with the camera.
homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker
version: 0.7.5+1
version: 0.7.6
Copy link
Contributor

@mvanbeusekom mvanbeusekom May 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's no public API change, it should be 0.7.5+2

Copy link
Contributor Author

@ydag ydag May 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

packages/image_picker/image_picker/CHANGELOG.md Outdated
@@ -1,3 +1,6 @@
## 0.7.6
* Implement UIAlertController with a preferredStyle of UIAlertControllerStyleAlert since UIAlertView is deprecated.
Copy link
Contributor

@mvanbeusekom mvanbeusekom May 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add back-ticks to indicate the UIAlertController, UIAlertControllerStyleAlert and UIAlertView are code constructs:

Suggested change
* Implement UIAlertController with a preferredStyle of UIAlertControllerStyleAlert since UIAlertView is deprecated.
* Implement `UIAlertController` with a preferredStyle of `UIAlertControllerStyleAlert` since `UIAlertView` is deprecated.

Copy link
Contributor Author

@ydag ydag May 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

mvanbeusekom
mvanbeusekom approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I noticed that @stuartmorgan also wanted to do a review so let's wait for him before we proceed.

I was a bit to quick, the CHANGELOG.md contains the wrong version number.

mvanbeusekom
mvanbeusekom suggested changes May 17, 2021
View reviewed changes
stuartmorgan-g
stuartmorgan-g approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CHANGELOG is fixed; sorry I forgot about this review last week, I meant to do it after the meeting.

mvanbeusekom
mvanbeusekom approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 17, 2021
@fluttergithubbot fluttergithubbot merged commit a3818f2 into flutter:master May 17, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
a3818f2 [image_picker] Image picker fix alert (flutter/plugins#3881)
268366b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
a3818f2 [image_picker] Image picker fix alert (flutter/plugins#3881)
f12c2a4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
a3818f2 [image_picker] Image picker fix alert (flutter/plugins#3881)
52265c7
@jmagman jmagman mentioned this pull request May 19, 2021
Merged
11 tasks
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@ydag @fotiDim
[image_picker] Image picker fix alert (flutter#3881)
df3ce0e
@mvanbeusekom mvanbeusekom deleted the image_picker_fix_alert branch September 21, 2021 09:33
jolmiracle pushed a commit to miracle-as/webview_flutter that referenced this pull request Sep 24, 2021
@ydag @jolmiracle
[image_picker] Image picker fix alert (flutter#3881)
28b4251 
# Conflicts:
#	packages/image_picker/image_picker/CHANGELOG.md
#	packages/image_picker/image_picker/pubspec.yaml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

2 more reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: image_picker platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

image picker: Suggest to stop using UIAlertView but use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead

4 participants

@ydag @stuartmorgan-g @mvanbeusekom @fluttergithubbot