[webview_flutter] Add setAllowFileAccess#3802
[webview_flutter] Add setAllowFileAccess#3802douglasiacovelli wants to merge 4 commits intoflutter:masterfrom
Conversation
|
Thanks for the submission! We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take some time before we’re able to review it. As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews, so we encourage you to file an issue (one that's not closed) and associate it with this PR. Note that this is not only an Android issue; see #3693, #3613, #2830. The eventual solution here should be an API that's designed to consider the needs of multiple platforms rather than just exposing one platform's APIs directly. |
|
/cc @mvanbeusekom |
|
I'm going to close this for now as the newly added ability to load local files and assets addresses the use cases we're aware of (and this implementation has been obsoleted by substantial rewrites to the plugin). If you need this functionality specifically, please file an issue explaining the use case, and we can discuss further there to decide if it's something we want to support. |
This PR intends to expose the method
allowFileAccesson Android, which might be a security concern explained in more detail here: https://labs.integrity.pt/articles/review-android-webviews-fileaccess-attack-vectors/index.htmlBesides that Android has changed the default behaviour of this after API 29 from true to false, meaning that developers who are willing to load local files won't be able to do so.
It solves part of this issue: flutter/flutter#37291
Pre-launch Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.