This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Closed
Conversation
This reverts commit 88466ff.
Contributor
|
Normally, I would not suggest this.... however, could we attempt to forward fix rather than reverting? We are now back to tracking master in g3 and reverting back to non-null-safe code is going to complicate things a lot. @blasten said the core reason is some of the package:test dependencies are not configured correctly even though package:test itself is migrated to null-safety so he is trying to fix it. |
Contributor
|
i think part of the reason is package shelf_static's nnbd version wasnt published. i pinged @kevmoo about it |
Author
|
dart-archive/shelf_static#45 fixes the issue momentarily |
Contributor
|
published latest |
Author
|
Cool, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter pub getis causing:Unfortunately, there is a bug in the script, and the tests never ran. https://cirrus-ci.com/task/5395059044515840
Reverts #3311