This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[file_selector] add GtkFileChooserDialog based implementation for Linux#3257
Closed
jpnurmi wants to merge 1 commit intoflutter:masterfrom
jpnurmi:file_selector_linux
Closed
[file_selector] add GtkFileChooserDialog based implementation for Linux#3257jpnurmi wants to merge 1 commit intoflutter:masterfrom jpnurmi:file_selector_linux
jpnurmi wants to merge 1 commit intoflutter:masterfrom
jpnurmi:file_selector_linux
Conversation
file_selector_linux needs to be endorsed in the app-facing file_selector package when done.
Member
Author
|
I ran |
Member
Author
Member
|
Thanks for the contribution! I'm totally unqualified to review linux code for now; @stuartmorgan is the boss here! |
Contributor
|
@robert-ancell would be the best person to do the initial review here. However, I'm confused why this was written from scratch when we already have the FDE file_chooser plugin; my plan was to simply convert that over to the new plugin's API (and in fact, I have that mostly done for macOS and Windows). Did you have an issue with that code? |
Member
Author
|
I see. I was simply not aware of the other implementation. |
Member
Author
|
No reason to spend time reviewing this since an implementation already exists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the FileSelector method channel interface for Linux. The implementation is based on GtkFileChooserDialog from GTK+ and has been tested with the example app in https://github.com/tugorez/plugins/tree/file_selector/packages/file_selector/file_selector/example
Related PRs
Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change