[url_launcher] Update readme for URL schemes on iOS#3252
[url_launcher] Update readme for URL schemes on iOS#3252fluttergithubbot merged 5 commits intoflutter:masterfrom
Conversation
| web, phone, SMS, and email schemes. | ||
| homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher | ||
| version: 5.7.10 | ||
| version: 5.7.10+1 |
There was a problem hiding this comment.
The next PATCH version must be 5.7.11
There was a problem hiding this comment.
Update doc can be just bumped by +1
Example
https://pub.dev/packages/image_picker/changelog#06710
https://pub.dev/packages/url_launcher/changelog#0421
https://pub.dev/packages/google_maps_flutter/changelog#052113
Also example from my last PR
https://github.com/flutter/plugins/pull/2932/files
There was a problem hiding this comment.
For package versions > 1.0.0, we shouldn't do +z .
Details in https://dart.dev/tools/pub/versioning#semantic-versions
Running version check for changed packages
packages/url_launcher/url_launcher/pubspec.yaml incorrectly updated version.
HEAD: 5.7.10+1, master: 5.7.10.
Allowed versions: {6.0.0: NextVersionType.BREAKING_MAJOR, 6.0.0-nullsafety: NextVersionType.MAJOR_NULLSAFETY_PRE_RELEASE, 5.8.0-nullsafety: NextVersionType.MINOR_NULLSAFETY_PRE_RELEASE, 5.8.0: NextVersionType.MINOR, 5.7.11: NextVersionType.PATCH}
There was a problem hiding this comment.
That's interesting, made the changes required.
Thank you
|
|
||
| ``` | ||
| <key>LSApplicationQueriesSchemes</key> | ||
| <array> |
There was a problem hiding this comment.
Does this cover other Schemes like mailto, tel and sms, or we must add new items for this property?
There was a problem hiding this comment.
Those schemes are supported without adding this so no new items are required
|
CC: @cyanglaz |
|
@hamdikahloun |
|
hi @TahaTesser |
a9ab05d to
e17673e
Compare
|
@hamdikahloun |
LGTM |
|
LGTM |
|
|
||
| ### iOS | ||
|
|
||
| Add the following keys to your _Info.plist_ file, located in `<project root>/ios/Runner/Info.plist`: |
There was a problem hiding this comment.
This is not an accurate summary of the requirement, and may still cause confusion. The correct description is that the scheme of any URL they pass to canLaunch should be listed, and the README should say that. You can give the below as an example, but you should make clear that it's an example.
There was a problem hiding this comment.
Made the changes, thanks!
| ## Installation | ||
|
|
||
| ### iOS | ||
| Add scheme for any URL passed on `canLaunch` to your _Info.plist_ file. |
There was a problem hiding this comment.
May be "Add any URL scheme passed to canLaunch in your Info.plist file."
002d571 to
b3ba69b
Compare
|
LGTM |
| ## Installation | ||
|
|
||
| ### iOS | ||
| Add any URL scheme passed to canLaunch in your Info.plist file. |
There was a problem hiding this comment.
Nits:
- Add `s around canLaunch
- s/in your/as
LSApplicationQueriesSchemesentries in your/
| </array> | ||
| ``` | ||
|
|
||
| See [canOpenURL](https://developer.apple.com/documentation/uikit/uiapplication/1622952-canopenurl) for more details. |
There was a problem hiding this comment.
Nit: the standard way to refer to an OjbC method without context includes the class, and the full signature (which includes the - and the :), like: -[UIApplication canOpenURL:]
See [`-[UIApplication canOpenURL:]`](...) for more details.
b3ba69b to
2781fd9
Compare
|
@stuartmorgan |
|
I've restarted the failed test, since it was a network issue. |
Description
Add instructions for iOS, for targeting iOS 9.0 and higher.
Note:
All new projects 1.22+ targets iOS 9.0 by default
Related Issues
Related to flutter/flutter#65936
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?