This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter_web][url_launcher_web][video_player_web] Remove custom analysis options#3230
Closed
amirh wants to merge 1 commit intoflutter:masterfrom
Closed
[google_maps_flutter_web][url_launcher_web][video_player_web] Remove custom analysis options#3230amirh wants to merge 1 commit intoflutter:masterfrom
amirh wants to merge 1 commit intoflutter:masterfrom
Conversation
…custom analysis files
Member
|
Local suppresses cannot be done to disable certain analysis checks, hence why they were added as See this. |
Contributor
Author
|
Strangely enough analysis passes cleanly for me locally with the inline ignores... not sure what's the difference on CI |
Member
|
@amirh maybe you have an old-ish version of the |
Contributor
Author
|
Seems like I had some locally cached state that prevented the analyzer from complaining. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the custom analysis options files for google_maps_flutter_web, url_launcher_web, and video_player_web, I added local suppresses to the undefined_prefixed_name warnings.
This is done to enable flutter/flutter#69309