This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter_platform_interface] Add dispose method.#2908
Merged
ditman merged 1 commit intoflutter:masterfrom Aug 10, 2020
Merged
[google_maps_flutter_platform_interface] Add dispose method.#2908ditman merged 1 commit intoflutter:masterfrom
ditman merged 1 commit intoflutter:masterfrom
Conversation
12 tasks
cyanglaz
reviewed
Aug 7, 2020
Contributor
cyanglaz
left a comment
There was a problem hiding this comment.
Who is going to be the caller? Each plugin decides when to call?
Contributor
|
Just saw #2909. will take another look. |
Member
Author
|
@cyanglaz This will be called on |
jarrodcolburn
pushed a commit
to jarrodcolburn/plugins
that referenced
this pull request
Aug 20, 2020
…#2908) This method gives the plugin writers a chance to release the resources that they've acquired throughout the operation of the plugin (think of it as an "inverse" of the "init" method).
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
…#2908) This method gives the plugin writers a chance to release the resources that they've acquired throughout the operation of the plugin (think of it as an "inverse" of the "init" method).
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…#2908) This method gives the plugin writers a chance to release the resources that they've acquired throughout the operation of the plugin (think of it as an "inverse" of the "init" method).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current version of the plugin does not have the ability to dispose of the resources that it grabs natively (I suppose the native side is able to clean itself up effectively).
The web implementation is not able to do so, and it needs a
disposemethod to dispose of the resources it grabs.This PR adds a
disposemethod to the platform interface package of google_maps_flutter, and a noop implementation for its MethodChannel implementation.The new method will be called on
disposeof the current GoogleMap widget, as seen here: #2909Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?