This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Update iOS platform target#2753
Closed
devtronic wants to merge 4 commits intoflutter:masterfrom
devtronic:devtronic-patch-1
Closed
[camera] Update iOS platform target#2753devtronic wants to merge 4 commits intoflutter:masterfrom devtronic:devtronic-patch-1
devtronic wants to merge 4 commits intoflutter:masterfrom
devtronic:devtronic-patch-1
Conversation
Author
|
What's wrong with the checks? |
Contributor
|
@devtronic It looks like the iOS tests are failing because the camera example app is supporting versions I don't think we want to go with this change because there could be a scenario where someone wants to compile for iOS We may want to go with another solution like updating the |
12 tasks
Contributor
|
Closing in favour of #3335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the camera package uses the AVCaptureDeviceDiscoverySession class, the minimum iOS SDK must be 10.0 (https://developer.apple.com/documentation/avfoundation/avcapturedevicediscoverysession)
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///). Not relevantflutter analyze) does not report any problems on my PR. Not relevantBreaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?