This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player]: updated video_player_web to use the new video_player_platform_interface#2741
Merged
gaaclarke merged 4 commits intoflutter:masterfrom May 7, 2020
Merged
Conversation
Contributor
|
LGTM assuming CI is going to pass. |
Member
Author
|
Landing on red, the CI error is an artifact of needing to update video_player as well, but I can't update video_player until this one lands. @cyanglaz and I think we've found a way to make this process easier next time. |
stuartmorgan-g
pushed a commit
to stuartmorgan-g/plugins
that referenced
this pull request
May 11, 2020
…platform_interface (flutter#2741)
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…platform_interface (flutter#2741)
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
…platform_interface (flutter#2741)
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…platform_interface (flutter#2741)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a necessary precondition for #2544 to pass CI. video_player has a dependency on video_player_web and you can't update video_player's video_player_platform_interface without updating it also for video_player_web.
Related Issues
flutter/flutter#32930
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?