This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera] A fix for stopImageStream method which solves a stale images bug#2655
Closed
topnax wants to merge 2 commits intoflutter:masterfrom
Closed
[camera] A fix for stopImageStream method which solves a stale images bug#2655topnax wants to merge 2 commits intoflutter:masterfrom
topnax wants to merge 2 commits intoflutter:masterfrom
Conversation
…ream, first few received images would be stale (typically images from the end of the first stream). This issue was caused by the absence of removing the image listener right after the cancellation of the image stream.
Contributor
|
This would be great if it were merged. |
|
What is stopping this from being merged? Would love this fix as it currently causes a bug in my app. |
12 tasks
Contributor
|
A fix for this bug is implemented and merged with PR #3344, therefore I will be closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where after starting another image stream subscription after the previous one was stopped, one or more images received were from the previous stream (they were stale). Better description and example is presented in the related issue.
Related Issues
flutter/flutter#54837
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?