This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[flutter_webview] Revert v2 embedder support#2200
Merged
mklim merged 3 commits intoflutter:masterfrom Oct 16, 2019
mklim:revert_webview_migration
Merged
[flutter_webview] Revert v2 embedder support#2200mklim merged 3 commits intoflutter:masterfrom mklim:revert_webview_migration
mklim merged 3 commits intoflutter:masterfrom
mklim:revert_webview_migration
Conversation
added 2 commits
October 16, 2019 12:08
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
The flutter_webview plugin needs an API in the v2 embedder that didn't roll into Flutter until `v1.10.9`, and the latest stable is `v.1.9.1`. In addition to this the migration already relied on some bugfixes that weren't really in stable, so the migration was shaky to begin with.
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
The flutter_webview plugin needs an API in the v2 embedder that didn't roll into Flutter until `v1.10.9`, and the latest stable is `v.1.9.1`. In addition to this the migration already relied on some bugfixes that weren't really in stable, so the migration was shaky to begin with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The flutter_webview plugin needs an API in the v2 embedder that didn't roll into Flutter until
v1.10.9, and the latest stable isv.1.9.1. In addition to this the migration already relied on some bugfixes that weren't really in stable, so the migration was shaky to begin with.Related Issues
Fixes flutter/flutter#42860.
Opens flutter/flutter#41851.
Related to flutter/flutter#42792.
Related to flutter/flutter#42377.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
/cc @matthew-carroll @collinjackson