Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Fix iOS build and analyzer warnings#2191

Merged
jmagman merged 1 commit intoflutter:masterfrom
jmagman:warnings-ip
Oct 15, 2019
Merged

[image_picker] Fix iOS build and analyzer warnings#2191
jmagman merged 1 commit intoflutter:masterfrom
jmagman:warnings-ip

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 15, 2019 •
edited
Loading

Description

Fix build and analyzer issues.

  • Leak
  • Nullability

Related Issues

Fixes flutter/flutter#42678.
Fixes flutter/flutter#30556.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jmagman jmagman requested a review from cyanglaz October 15, 2019 00:38
@jmagman jmagman mentioned this pull request Oct 15, 2019
Closed
cyanglaz
cyanglaz approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit fb37cfc into flutter:master Oct 15, 2019
@jmagman jmagman deleted the warnings-ip branch October 15, 2019 17:53
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
@jmagman @mormih
[image_picker] Fix iOS build and analyzer warnings (flutter#2191)
f7d8a87
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
@jmagman
[image_picker] Fix iOS build and analyzer warnings (flutter#2191)
e39b561
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[image_picker] Fix clang analyzer warnings in iOS platform code [image_picker] sample crashes on ios after 3-4 camera shots. Probably memory leak

3 participants

@jmagman @cyanglaz @googlebot