Add web url launcher by harryterkelsen · Pull Request #2119 · flutter/plugins

harryterkelsen · 2019-09-27T23:49:21Z

Description

Adds the url_launcher_web plugin, the Web platform implementation of url_launcher.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

amirh

overall looks good.

One minor detail - but one that we should decide on one and will probably affect all platform implementations for all plugins: url_launcher_<platform> or <platform>_url_launcher ? my tendency is to go with the former as that what we already used for fuchsia webview, and in the http://flutter.dev/go/federated-plugins which was reviewed by multiple people and no one commented on the naming...
I also feel like people the name should emphasize that this is a implementation more than that this is for the url_launcher plugin (especially once it get endorsed we don't expect people to find this plugin in pub and use it...)

Again it's a minor detail and I wouldn't spend the time discussing it normally, but once we publish there's no way back and as we'll probably want to be consistent across all plugins/platforms this is going to set the naming convention for all of them...

amirh · 2019-09-28T00:53:36Z

packages/url_launcher/url_launcher_web/test/url_launcher_web_test.dart

+    test('cannot launch "tel" URLs', () {
+      expect(canLaunch('tel:5551234567'), completion(isFalse));
+    });
+  });


is there a way to test launch ?

It would require a lot of extra code. Rather than running the test using flutter test --platform chrome we would have to spin up our own instance of Chrome, somehow build the JS getting the Flutter Web SDK from somewhere, call launch, and determine that a new tab was opened with the correct API.

I added some basic tests for launch

packages/url_launcher/url_launcher/pubspec.yaml

stuartmorgan-g · 2019-09-29T21:33:34Z

url_launcher_<platform> or <platform>_url_launcher ? my tendency is to go with the former as that what we already used for fuchsia webview,

I think you mean the latter?

(especially once it get endorsed we don't expect people to find this plugin in pub and use it...)

Except that the doc explicitly describes cases (API extension) where people will directly use the implementation package; in that case, having foo_plugin and foo_plugin_bar in their pubspec.yaml is clearer than bar_foo_plugin.

But in the directory structure we picked having the platform first is probably nicer in terms of navigating the repository, so I think both have relatively small pros and cons, and either is fine with me.

stuartmorgan-g · 2019-09-29T21:40:33Z

The web implementation package doesn't include the dummy iOS and Android files, so adding this to a project that targets iOS and/or Android will break them. Do you want to add the workaround, or are we just waiting for the real fixes to the Flutter plugin tooling on that?

amirh · 2019-09-30T16:56:25Z

url_launcher_<platform> or <platform>_url_launcher ? my tendency is to go with the former as that what we already used for fuchsia webview,

I think you mean the latter?

Oops, yes the latter.

harryterkelsen · 2019-09-30T20:21:32Z

I have a slight preference for url_launcher_<platform> because "Web_____" may lead to confusion (for example, a plugin name starting with "view" or "assembly"), but I'm okay either way

harryterkelsen · 2019-09-30T21:09:06Z

FYI, I changed the incremental_build.sh script to not ignore plugin folders without a pubspec.yaml (since this would also cause us to ignore all federated plugins).

Add url_launcher_web package Test plugins even if they don't have a pubspec in the top-level folder Bump up the pubspec version for new homepage URL Add dummy podspec file for iOS Remove unused import Format test Update check_publish.sh script

harryterkelsen · 2019-09-30T22:52:17Z

I updated the PR so the tests run, and the publish check works properly, PTAL

packages/url_launcher/url_launcher/CHANGELOG.md

amirh · 2019-10-01T17:03:36Z

I have a slight preference for url_launcher_<platform> because "Web_____" may lead to confusion (for example, a plugin name starting with "view" or "assembly"), but I'm okay either way

Ok, lets keep the current name.

amirh

Left a few comments on the CI scripts, I think that change probably worth a separate PR though.

amirh · 2019-10-01T17:25:10Z

script/common.sh

-      CHANGED_PACKAGES="${CHANGED_PACKAGES},$package"
-      CHANGED_PACKAGE_LIST=("${CHANGED_PACKAGE_LIST[@]}" "$package")
-    fi
+    CHANGED_PACKAGES="${CHANGED_PACKAGES},$package"


Seems like the pubspec.yaml logic was introduced to prevent a deleted package to be running on CI, maybe we can just check that the directory exists instead?

cc @gspencergoog who originally introduce this logic.

Changed this to check if the directory exists

amirh · 2019-10-01T17:27:22Z

script/check_publish.sh

  local failures=()
-  for package_name in "$@"; do
-    local dir="$REPO_DIR/packages/$package_name"
+  for dir in $(pub global run flutter_plugin_tools list --plugins="$1"); do


Seems wrong to only look at the first argument (prior to this change it would check the packages for all arguments)

That was because previously, check_publish was called with the dereferenced CHANGED_PACKAGE_LIST array, which passed the array items as separate arguments. Now there is only one argument, the packages list in a comma-separated list.

amirh

LGTM

Follows the structure established in flutter#2119 to add a federated macOS implementation of the url_launcher plugin. Fixes macOS portion of flutter/flutter#41721

* Move url_launcher to url_launcher/url_launcher Add url_launcher_web package Test plugins even if they don't have a pubspec in the top-level folder Bump up the pubspec version for new homepage URL Add dummy podspec file for iOS Remove unused import Format test Update check_publish.sh script * UPdate check_publish for federated plugins. * Follow correct semver when bumping version * Add some tests for `launch` * Check if directory exists for CI

harryterkelsen requested a review from mklim as a code owner September 27, 2019 23:49

googlebot added the cla: yes label Sep 27, 2019

mklim requested a review from amirh September 27, 2019 23:51

amirh reviewed Sep 28, 2019

View reviewed changes

packages/url_launcher/url_launcher/pubspec.yaml Outdated Show resolved Hide resolved

harryterkelsen added 2 commits September 30, 2019 14:59

UPdate check_publish for federated plugins.

53938a8

amirh reviewed Oct 1, 2019

View reviewed changes

packages/url_launcher/url_launcher/CHANGELOG.md Outdated Show resolved Hide resolved

Follow correct semver when bumping version

5b48d74

amirh reviewed Oct 1, 2019

View reviewed changes

harryterkelsen added 2 commits October 1, 2019 13:11

Add some tests for launch

2d9a6a8

Check if directory exists for CI

d5fee1e

amirh approved these changes Oct 2, 2019

View reviewed changes

harryterkelsen merged commit 1d5301d into flutter:master Oct 2, 2019

stuartmorgan-g mentioned this pull request Oct 14, 2019

[url_launcher] Adds macOS support #2187

Closed

13 tasks

Conversation

harryterkelsen commented Sep 27, 2019

Description

Checklist

Breaking Change

Uh oh!

amirh left a comment

Choose a reason for hiding this comment

Uh oh!

amirh Sep 28, 2019

Choose a reason for hiding this comment

Uh oh!

harryterkelsen Sep 30, 2019

Choose a reason for hiding this comment

Uh oh!

harryterkelsen Oct 1, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stuartmorgan-g commented Sep 29, 2019

Uh oh!

stuartmorgan-g commented Sep 29, 2019

Uh oh!

amirh commented Sep 30, 2019

Uh oh!

harryterkelsen commented Sep 30, 2019

Uh oh!

harryterkelsen commented Sep 30, 2019

Uh oh!

harryterkelsen commented Sep 30, 2019

Uh oh!

Uh oh!

amirh commented Oct 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amirh left a comment

Choose a reason for hiding this comment

Uh oh!

amirh Oct 1, 2019

Choose a reason for hiding this comment

Uh oh!

harryterkelsen Oct 1, 2019

Choose a reason for hiding this comment

Uh oh!

amirh Oct 1, 2019

Choose a reason for hiding this comment

Uh oh!

harryterkelsen Oct 1, 2019

Choose a reason for hiding this comment

Uh oh!

amirh left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

amirh commented Oct 1, 2019 •

edited

Loading