[image_picker] Fix ios scaling in portrait mode#2060
[image_picker] Fix ios scaling in portrait mode#2060Xavjer wants to merge 3 commits intoflutter:masterfrom
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
Reopening due to wrong commiter idenitity |
|
issue still on lates version image_picker: ^0.6.1+4 |
|
@Xgamefactory this PR was not merged, recreated in #2061 but not merged yet, therefore the error still exists |
…tform interface) (flutter#2060) * Updated `FieldValueFactoryPlatform` to use generics. * `FieldValuePlatform` no longer extends `PlatformInterface`. * `MethodChannelFieldValue` no longer extends `FieldValuePlatform` and supports equality comparison. * Fixed the file name of a test.
Description
Fixes the issue, that within image_picker when taking a picture on iOS in Portrait mode, the scaling did not work as intended (AspectRatio was flipped)
Related Issues
flutter/flutter#40334 => Will be fixed with this PR
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.=> No new unit tests added, as the existing should already cover this, but the image did not have the values that were returned from the channel.
///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?