This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] Remove skipped driver test#2027
Merged
mklim merged 2 commits intoflutter:masterfrom Aug 28, 2019
mklim:remove_iap_driver_test
Merged
[in_app_purchase] Remove skipped driver test#2027mklim merged 2 commits intoflutter:masterfrom mklim:remove_iap_driver_test
mklim merged 2 commits intoflutter:masterfrom
mklim:remove_iap_driver_test
Conversation
This test was never providing much value since it needed to be run manually and only verified one of the API calls. Manually opening the configured example app took just as much time and verified much more. CI is failing based on it being skipped right now. Remove it completely to unbreak CI.
cyanglaz
approved these changes
Aug 28, 2019
Contributor
cyanglaz
left a comment
There was a problem hiding this comment.
LGTM! Remember to update version and CHANGELOG before commit
Contributor
Author
I wasn't planning on publishing the changes here on their own since they're just removing a normally unused test within the plugin itself. Do you think it's worth pushing? |
Contributor
|
Personally I'm in favor of releasing whenever anything changes, patch changes don't really create work for anyone and it avoids a situation where someone could be confused by differences between pub and GitHub. |
Contributor
Author
|
Makes sense, updated. |
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
This test was never providing much value since it needed to be run manually and only verified one of the API calls. Manually opening the configured example app took just as much time and verified much more. CI is failing based on it being skipped right now. Remove it completely to unbreak CI.
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
This test was never providing much value since it needed to be run manually and only verified one of the API calls. Manually opening the configured example app took just as much time and verified much more. CI is failing based on it being skipped right now. Remove it completely to unbreak CI.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Add macOS availability to the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This test was never providing much value since it needed to be run
manually and only verified one of the API calls. Manually opening the
configured example app took just as much time and verified much more. CI
is failing based on it being skipped right now. Remove it completely to
unbreak CI.
Related Issues
flutter/flutter#29462
https://cirrus-ci.com/task/5776347504312320
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
/cc @BugsBunnyBR