This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[Image_picker] fix retrieveImage breakage, added tests.#2010
Merged
cyanglaz merged 2 commits intoflutter:masterfrom Aug 24, 2019
Merged
[Image_picker] fix retrieveImage breakage, added tests.#2010cyanglaz merged 2 commits intoflutter:masterfrom
retrieveImage breakage, added tests.#2010cyanglaz merged 2 commits intoflutter:masterfrom
Conversation
collinjackson
approved these changes
Aug 24, 2019
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Image picker retrieveImage broke after #1877
This PR is to fix the crash.
Also added tests for the fix.
Related Issues
flutter/flutter#38025
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?