[firebase_auth] use long datatype for timestamps (iOS)#1973
[firebase_auth] use long datatype for timestamps (iOS)#1973kroikie merged 2 commits intoflutter:masterfrom
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
2a0c7af to
c3bb584
Compare
|
@ened this looks good, thanks. Could you bump the version and add a note in the CHANGELOG before I merge? |
* [firebase_auth] use long datatype for timestamps (iOS)
* [firebase_auth] use long datatype for timestamps (iOS)
Description
Reduces a few compiler warnings in the firebase_auth plugin that were caused by using
[NSNumber numberWithInt]whennumberWithLongwould have worked as well.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?