Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Fix permissions bug in sample code.#1958

Merged
mehmetf merged 1 commit intoflutter:masterfrom
mehmetf:b97
Aug 8, 2019
Merged

[camera] Fix permissions bug in sample code.#1958
mehmetf merged 1 commit intoflutter:masterfrom
mehmetf:b97

Conversation

@mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Aug 7, 2019

Permission requests force app to go into background triggering a controller.dispose() before the controller is even initialized. After the permission is granted, you end up with an exception.

We should not dispose or reinit a controller if it is not inited yet.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehmetf mehmetf merged commit 3aa087c into flutter:master Aug 8, 2019
@mehmetf mehmetf deleted the b97 branch August 8, 2019 19:05
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants