This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[Firebase Analytics] Update AGP, remove deprecated method and remove castings#1938
Merged
collinjackson merged 8 commits intoflutter:masterfrom Aug 6, 2019
juliocbcotta:plugin/firebase_analytics_review
Merged
[Firebase Analytics] Update AGP, remove deprecated method and remove castings#1938collinjackson merged 8 commits intoflutter:masterfrom juliocbcotta:plugin/firebase_analytics_review
collinjackson merged 8 commits intoflutter:masterfrom
juliocbcotta:plugin/firebase_analytics_review
Conversation
| /// | ||
| /// FirebaseAnalytics analytics = FirebaseAnalytics(); | ||
| /// analytics.android?.setMinimumSessionDuration(200000); | ||
| /// analytics.android?.setAnalyticsCollectionEnabled(true); |
Contributor
There was a problem hiding this comment.
It might be less confusing to use setSessionTimeoutDuration since setAnalyticsCollectionEnabled is on the main class.
Also, since we're doing a breaking change here it might make sense to remove setAnalyticsCollectionEnabled from the FirebaseAnalyticsAndroid
| @@ -1,3 +1,9 @@ | |||
| ## 5.0.0 | |||
|
|
|||
| * Android : Remove deprecated method `setMinimumSessionDuration`. | |||
Contributor
There was a problem hiding this comment.
Nit: Can you make this more consistent with other CHANGELOG entries, e.g. the one below it.? Make sure to indicate the removal of methods as a breaking change.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…castings (flutter#1938) * Update AGP and Gradle. * Remove deprecated Android method setMinimumSessionDuration. * Removed reduntant casting * remove `FirebaseAnalyticsAndroid.setAnalyticsCollectionEnabled`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?