This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Split Activity and plugin files#1936
Merged
mklim merged 6 commits intoflutter:masterfrom Aug 2, 2019
juliocbcotta:plugin/url_launcher_review
Merged
[url_launcher] Split Activity and plugin files#1936mklim merged 6 commits intoflutter:masterfrom juliocbcotta:plugin/url_launcher_review
mklim merged 6 commits intoflutter:masterfrom
juliocbcotta:plugin/url_launcher_review
Conversation
mklim
reviewed
Aug 1, 2019
Contributor
mklim
left a comment
There was a problem hiding this comment.
Thanks for fixing this up!
Basic changes look good, just have a couple minor nits.
packages/url_launcher/CHANGELOG.md
Outdated
| @@ -1,3 +1,8 @@ | |||
| ## 5.1.1+1 | |||
Contributor
There was a problem hiding this comment.
nit: This should be 5.1.2 here and in pubspec.yaml. Pubspec changes its versioning scheme depending on if a package is above or below 1.0.0. For below it's 0.major.minor+patch, but for above it's major.minor.patch.
| /* Launches WebView activity */ | ||
| public class WebViewActivity extends Activity { | ||
|
|
||
| public static String ACTION_CLOSE = "close action"; |
Contributor
There was a problem hiding this comment.
nit: Some Javadoc explaining what this constant is used for would be useful. https://google.github.io/styleguide/javaguide.html#s7.3-javadoc-where-required
I didn't realize spaces were supported here. Neat.
- add javadoc.
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
This PR : - Updates AGP and Gradle versions. - Splits WebViewActivity and the plugin class to improve separation of concerns. The separation of classes and files provides encapsulation for constants used in the WebViewActivity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR :
The separation of classes and files provides encapsulation for constants used in the WebViewActivity.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?