This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[cloud_firestore] Update autoId generation to match native implementation more closely#1907
Merged
collinjackson merged 2 commits intoflutter:masterfrom Jul 26, 2019
Merged
Conversation
Contributor
|
@KevinTheGray Thanks for this PR, looks good to me, once the tests pass I will merge. |
collinjackson
approved these changes
Jul 26, 2019
| @@ -1,3 +1,7 @@ | |||
| ## 0.12.8 | |||
|
|
|||
| * Updated how document Ids are generated to more closely match native implementations. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * Updated how document Ids are generated to more closely match native implementations. | |
| * Updated how document ids are generated to more closely match native implementations. |
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
…tion more closely (flutter#1907)
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…tion more closely (flutter#1907)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the flutter implementation of Firestore generates a new document ID in the same way it is geenrated for the RTDB. However, this behavior has been modified for Firestore, and it no longer generates IDs in the same way. I was motivated to make this change because:
The plugins should behave as close as possible to the native implementation. It was very obvious to me when I saw the keys that were being generated that they were not mimicking expected behavior.
It's probably negligible, but the new code is a lot less complex and under less constraints.
Related Issues
flutter/flutter#15715
flutter/flutter#15715 is resolved because it now matches how the Android/iOS generate document IDs. That is, from the pool of characters from String "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789", we choose 20 random ones and generate an ID.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?