This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] image picker memory leak fix on Android#1893
Merged
cyanglaz merged 7 commits intoflutter:masterfrom Jul 29, 2019
juliocbcotta:plugin/image_picker_memory_leak_fix
Merged
[image_picker] image picker memory leak fix on Android#1893cyanglaz merged 7 commits intoflutter:masterfrom juliocbcotta:plugin/image_picker_memory_leak_fix
cyanglaz merged 7 commits intoflutter:masterfrom
juliocbcotta:plugin/image_picker_memory_leak_fix
Conversation
Contributor
|
CI seems not happy about some java unit tests |
Contributor
Author
|
@cyanglaz it is green. |
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
|
image_picker 有图片压缩的功能api吗 |
Contributor
|
@qwerqwq 目前还没有。如果您有兴趣可以开一个pr :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to fix a memory leak in image picker plugin by unregistering the ActivityLifecycleCallbacks in the onDestroy of the view.
Related Issues
flutter/flutter#36520
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?