This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider] Add support to access getApplicationSupportDirectory on Android#1891
Merged
collinjackson merged 6 commits intoflutter:masterfrom Jul 24, 2019
juliocbcotta:plugin/path_provider
Merged
[path_provider] Add support to access getApplicationSupportDirectory on Android#1891collinjackson merged 6 commits intoflutter:masterfrom juliocbcotta:plugin/path_provider
collinjackson merged 6 commits intoflutter:masterfrom
juliocbcotta:plugin/path_provider
Conversation
collinjackson
approved these changes
Jul 23, 2019
Contributor
collinjackson
left a comment
There was a problem hiding this comment.
Thanks for the PR! This looks good to me. I've added a bit more to the CHANGELOG to cover the unrelated change.
packages/path_provider/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 1.2.0 | |||
|
|
|||
| * Android: `getApplicationSupportDirectory` enabled by using `getFilesDir`. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * Android: `getApplicationSupportDirectory` enabled by using `getFilesDir`. | |
| * On Android, `getApplicationSupportDirectory` is now supported and uses `getFilesDir`. | |
| * `getStorageDirectory` now returns `null` instead of throwing an exception if no external files directory is available. |
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
…on Android (flutter#1891) * add support to access android filesDir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the plugin to use
getApplicationSupportDirectoryon android.on iOS apple says : https://developer.apple.com/library/archive/documentation/FileManagement/Conceptual/FileSystemProgrammingGuide/FileSystemOverview/FileSystemOverview.html
This is very close of the usage of
getFilesDiron Android. It is private to the app, there is no sync and the app can use to save files that are not temporary (cache).Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
I don't know if it is a breaking change. What worked before should keep working know, but it does change the behavior of a method.
Does your PR require plugin users to manually update their apps to accommodate your change?