This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Cirrus should report errors on failures of incremental_build.sh#1870
Merged
collinjackson merged 5 commits intoflutter:masterfrom Jul 17, 2019
Merged
Cirrus should report errors on failures of incremental_build.sh#1870collinjackson merged 5 commits intoflutter:masterfrom
collinjackson merged 5 commits intoflutter:masterfrom
Conversation
13 tasks
fkorotkov
approved these changes
Jul 17, 2019
| local packages | ||
| local branch_base_sha="$(get_branch_base_sha)" | ||
| if [[ "$?" == 0 ]]; then | ||
| if [[ "$branch_base_sha" != "" ]]; then |
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like we're testing whether the assignment of an environment variable succeeds instead of whether the environment variable actually is set to something.
Example of a masked failure: https://cirrus-ci.com/task/4977285139005440
See also #1864