This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Dart Interface for camera refactor#1832
Merged
bparrishMines merged 5 commits intoflutter:masterfrom Jul 11, 2019
Merged
[camera] Dart Interface for camera refactor#1832bparrishMines merged 5 commits intoflutter:masterfrom
bparrishMines merged 5 commits intoflutter:masterfrom
Conversation
11 tasks
mklim
approved these changes
Jul 10, 2019
Contributor
mklim
left a comment
There was a problem hiding this comment.
LGTM
nit: Can you add a quick README to /new saying that this is a work in progress, and link to the issue tracking the refactor?
| /// | ||
| /// This class is used as a simple interface that works for Android and iOS. | ||
| /// | ||
| /// When using iOS, simultaneously calling [start] on two [CameraController]s |
Contributor
There was a problem hiding this comment.
Thanks for clarifying!
Discussed offline, I'm thinking this is kind of a foot gun. Sounds like the current plugin behavior is to guard against this by disposing of multiple instances under the hood. I think we should probably maintain it here, but that doesn't need to block this PR.
13 tasks
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Beginning of refactor of the camera plugin. This only implements the camera interface and shared classes (e.g. camera mixins,
CameraChannel&CameraTesting)This also adds the
publish_to: noneto thepubspec.yamluntil the refactor is finished.Related Issues
flutter/flutter#31225
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?