This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] Fixed code example error & README links #1751
Merged
mklim merged 9 commits intoflutter:masterfrom Jul 9, 2019
creativecreatorormaybenot:iap-readme-fixes
Merged
[in_app_purchase] Fixed code example error & README links #1751mklim merged 9 commits intoflutter:masterfrom creativecreatorormaybenot:iap-readme-fixes
mklim merged 9 commits intoflutter:masterfrom
creativecreatorormaybenot:iap-readme-fixes
Conversation
Contributor
Author
mklim
reviewed
Jul 8, 2019
Contributor
mklim
left a comment
There was a problem hiding this comment.
Thank you for the fix!
One nit: this also needs pubspec.yaml to be updated.
Contributor
Author
|
@mklim Done. |
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
```dart const Set<String> _kIds = <String>['product1', 'product2'].toSet(); ``` That is not a valid assignment. Hence, I fixed it and on the way I also updated all the links in the README that either did not work at all or did not work from the [pub page](https://pub.dev/packages/in_app_purchase#-readme-tab-).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is not a valid assignment. Hence, I fixed it and on the way I also updated all the links in the README that either did not work at all or did not work from the pub page.