This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter] ios build fix#1734
Merged
iskakaushik merged 3 commits intoflutter:masterfrom Jun 20, 2019
OreOreDa:master
Merged
[google_maps_flutter] ios build fix#1734iskakaushik merged 3 commits intoflutter:masterfrom OreOreDa:master
iskakaushik merged 3 commits intoflutter:masterfrom
OreOreDa:master
Conversation
Contributor
Author
|
Some checks failed due to github timeouts (?), I re created this PR to have the checks run again, and have the green mark |
Contributor
|
@OreOreDa could you please edit the pubspec.yaml change version to |
Contributor
Author
|
Sure, Iska 👍 Done |
Contributor
|
LGTM. This fixes flutter/flutter#34042 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create a new Flutter project with "flutter create"
Add the latest google maps flutter plugin in pubspec.yaml
build for iOS fails with latest version of XCode / Flutter SDK with error "GoogleMapsBase not found", because of GoogleMaps.framework headers:
#if __has_feature(modules)
@import GoogleMapsBase; <--- this is taken by default with a non-modified Flutter project
#else
#import <GoogleMapsBase/GoogleMapsBase.h>
#endif
This is a known issue, it has been solved for React Native : https://github.com/googlemaps/google-maps-ios-utils/pull/20/files
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?