This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Fix wrong main thread checking condition.#1602
Merged
amirh merged 2 commits intoflutter:masterfrom May 15, 2019
Merged
[webview_flutter] Fix wrong main thread checking condition.#1602amirh merged 2 commits intoflutter:masterfrom
amirh merged 2 commits intoflutter:masterfrom
Conversation
The Android JavaScriptChannel wasn't checking correctly if messages are received on the main thread and took the branch that assumes we are on the main thread. flutter/engine#8830 causes this behavior to fail (which is good). So now we can also add an e2e test that fails with the buggy behavior.
c2cb6a6 to
6d9d9dd
Compare
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Android JavaScriptChannel wasn't checking correctly if messages are
received on the main thread and took the branch that assumes we are on
the main thread.
flutter/engine#8830 causes this behavior to fail
(which is good). So now we can also add an e2e test that fails with the
buggy behavior.
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?