This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_performance] Testing of firebase performance rewrite PRs#1557
Merged
bparrishMines merged 56 commits intoflutter:masterfrom May 14, 2019
Merged
[firebase_performance] Testing of firebase performance rewrite PRs#1557bparrishMines merged 56 commits intoflutter:masterfrom
bparrishMines merged 56 commits intoflutter:masterfrom
Conversation
This was referenced May 14, 2019
collinjackson
approved these changes
May 14, 2019
Contributor
There was a problem hiding this comment.
This change LGTM. Minor nit though, I think that assigning test data to variables in unit tests is discouraged and that we're encouraging less code re-use in favor of making the tests more declarative. For example, instead of assigning value to 'apple' you could say 'apple' everywhere.
@amirh may have more opinions about this. I realize this guideline is a bit unintuitive and I don't feel strongly about it, probably we should write it down either way.
Contributor
Author
|
I was thinking about this as well. I typically always use literals, but I wanted to make this PR a little shorter and be focused on the refactor while the next one will be focused on tests. |
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reformat
firebase_performanceplugin to enable the use of meaningful integration testing.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?