Skip to content

Roll Flutter master to 824868f5d1e6c091a5df23d3628407e75149e1da#9416

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
stuartmorgan-g:manual-roll-824868f5d1e6
Jun 11, 2025
Merged

Roll Flutter master to 824868f5d1e6c091a5df23d3628407e75149e1da#9416
auto-submit[bot] merged 2 commits intoflutter:mainfrom
stuartmorgan-g:manual-roll-824868f5d1e6

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Jun 11, 2025 •
edited
Loading

Rolls Flutter master version to 824868f

flutter/flutter@2d9977c...824868f

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jun 11, 2025

Android failures are probably flutter/flutter#169884

Package install error: Failure [INSTALL_FAILED_NO_MATCHING_ABIS]

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jun 11, 2025

Trying the emulator version from flutter/flutter#158017, which it looks like at least some flutter/flutter configs are still using.

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jun 11, 2025

Wait, that's the version we're already using. Now I'm confused.

@reidbaker Any idea why we're getting emulator failures suggesting we're using x86 emulators if the avd_cipd_version is the same as in flutter/flutter?

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jun 11, 2025 •
edited
Loading

Oh, never mind, it's the legacy tests that are failing, so the issue is {"dependency": "android_virtual_device", "version": "generic_android22.textpb"}, which is indeed x86.

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jun 11, 2025

Hm, it looks from https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/android/avd/proto like API 30 or 31 is the oldest we can now go with the "legacy" tests. We're going to lose a lot of safety about continuing to work on older versions of Android.

@stuartmorgan-g stuartmorgan-g force-pushed the manual-roll-824868f5d1e6 branch from db65153 to 4337bc7 Compare June 11, 2025 17:32
@stuartmorgan-g stuartmorgan-g requested a review from reidbaker June 11, 2025 17:32
@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jun 11, 2025

@reidbaker Do you have any better ideas than us making API 31 our "old" test device?

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jun 11, 2025

We're going to lose a lot of safety about continuing to work on older versions of Android.

(The counterpoint is that I don't think we've actually had many cases of things that only failed these tests.)

@reidbaker
Copy link
Contributor

reidbaker commented Jun 11, 2025

Is 31 the oldest device that has a non x86 image? If you haven't checked then I can.

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jun 11, 2025

From the link above, the only older one I can find is android_30_google_atd_x64. I'm not clear what the atd vs api distinction is though.

@reidbaker
Copy link
Contributor

reidbaker commented Jun 11, 2025

Our only other option would be authoring one of those proto files and getting chromium to accept it.

https://github.com/chromium/chromium/blob/main/docs%2Fandroid_emulator.md

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jun 11, 2025

In that case, since the roller is currently over a week behind and this is a blocker, I would like to land this rather than block for an unknown amount of time. Any objection to that?

Should I file a team-android bug for investigating configuring and switching to an older x64 device as a follow-up?

@reidbaker
Copy link
Contributor

reidbaker commented Jun 11, 2025

No objection to setting the old tests to api 31

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 11, 2025
@stuartmorgan-g stuartmorgan-g mentioned this pull request Jun 11, 2025
Open
@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jun 11, 2025

Thanks! I filed flutter/flutter#170474 to make sure we don't forget to at least consider adjusting it later.

@auto-submit auto-submit bot merged commit 6d3aaf4 into flutter:main Jun 11, 2025
79 checks passed
@stuartmorgan-g stuartmorgan-g deleted the manual-roll-824868f5d1e6 branch June 11, 2025 20:34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 12, 2025
@engine-flutter-autoroll
6d3aaf4 Roll Flutter master to 824868f (flutter/packages#9416)
61ad210
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2025
Merged
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jun 12, 2025
@engine-flutter-autoroll
Roll Packages from 0b322a2 to 6d3aaf4 (2 revisions) (#170528)
5d043d9 
flutter/packages@0b322a2...6d3aaf4

2025-06-11 stuartmorgan@google.com Roll Flutter master to
824868f (flutter/packages#9416)
2025-06-11 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Adds support for companion ads
(flutter/packages#9260)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@stuartmorgan-g @Ortes
Roll Flutter master to 824868f (flutter#9416)
3625530 
Rolls Flutter master version to 824868f

flutter/flutter@2d9977c...824868f
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@engine-flutter-autoroll @mboetger
Roll Packages from 0b322a2 to 6d3aaf4 (2 revisions) (flutter#170528)
fc9de25 
flutter/packages@0b322a2...6d3aaf4

2025-06-11 stuartmorgan@google.com Roll Flutter master to
824868f (flutter/packages#9416)
2025-06-11 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Adds support for companion ads
(flutter/packages#9260)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
@stuartmorgan-g @vashworth
Roll Flutter master to 824868f (flutter#9416)
9067c74 
Rolls Flutter master version to 824868f

flutter/flutter@2d9977c...824868f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@reidbaker reidbaker Awaiting requested review from reidbaker

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stuartmorgan-g @reidbaker @tarrinneal