Roll Flutter (stable) from c23637390482 to be698c48a675 (1274 revisions)

[engine-flutter-autoroll]

flutter/flutter@c236373...be698c4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-stable-packages
Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter (stable): https://github.com/flutter/flutter/issues/new/choose
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[auto-submit]

autosubmit label was removed for flutter/packages/9300, because - The status or check suite Linux_web web_platform_tests_shard_3 stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

• The status or check suite Linux_web web_platform_tests_wasm_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
• The status or check suite Linux_web web_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
• The status or check suite Linux_android android_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
• The status or check suite Linux_android android_build_all_packages_legacy stable has failed. Please fix the issues identified (or deflake) before re-applying this label.
• The status or check suite cla/google has failed. Please fix the issues identified (or deflake) before re-applying this label.

[auto-submit]

autosubmit label was removed for flutter/packages/9300, because - The status or check suite Linux_web web_platform_tests_shard_3 stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

• The status or check suite Linux_web web_platform_tests_wasm_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
• The status or check suite Linux_web web_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
• The status or check suite Linux_android android_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
• The status or check suite Linux_android android_build_all_packages_legacy stable has failed. Please fix the issues identified (or deflake) before re-applying this label.
• The status or check suite cla/google has failed. Please fix the issues identified (or deflake) before re-applying this label.

[engine-flutter-autoroll]

Commit queue failed; closing this roll.

[stuartmorgan-g]

@gmackall Any idea what this failure in the legacy build-all is?

* What went wrong:
A problem occurred configuring project ':camera_android'.
> Parameter specified as non-null is null: method com.flutter.gradle.VersionUtils.mostRecentSemanticVersion, parameter version1

Do we need to update part of the toolchain in the legacy project to work with 3.32?

[gmackall]

mostRecentSemanticVersion

It looks like this method is taking as argument NDK versions here
https://github.com/flutter/flutter/blob/63903561033d7fc2f33b67239f2002d0ee529b48/packages/flutter_tools/gradle/src/main/kotlin/FlutterPluginUtils.kt#L559-L562
which are in newer AGP versions not nullable, but perhaps this is running on an old AGP version for which it is nullable? If so, and the AGP version is within our support range, this is a bug in our FGP code that we should fix.

[gmackall]

Ok yes it looks like this changed from AGP 8.1 to AGP 8.2
https://developer.android.com/reference/tools/gradle-api/8.1/com/android/build/api/dsl/CommonExtension#ndkVersion()
https://developer.android.com/reference/tools/gradle-api/8.2/com/android/build/api/dsl/CommonExtension#ndkVersion()

[stuartmorgan-g]

Hm, I wonder why we never hit this on android_build_all_packages_legacy master.

[stuartmorgan-g]

Oh, did we hit this on master, and fix it, but the regression and fix were on opposite sides of the branch point maybe?

[gmackall]

Yeah, I suppose there must be something weird going on with branching? Because yes I think this was fixed by flutter/flutter#167011

[stuartmorgan-g]

Yeah, I suppose there must be something weird going on with branching? Because yes I think this was fixed by flutter/flutter#167011

Yes, flutter/flutter#166727 was in 3.32, none of the follow-ups to fix this issue were. Should they be cherry-picked? /cc @reidbaker

If we don't, it seems like a bunch of plugins will be broken with older versions of AGP.

[stuartmorgan-g]

Meanwhile I'm going to disable this test on stable to unblock getting flutter/packages on the current stable, with an issue to track fixing it and re-enabling it.

Edit: filed flutter/flutter#169290

[reidbaker]

@gmackall can you take care of requesting the cherry picks?

[gmackall]

@gmackall can you take care of requesting the cherry picks?

flutter/flutter#169289