[go_router] Fix requestFocus propagation to Navigator#9177
Merged
auto-submit[bot] merged 5 commits intoflutter:mainfrom May 8, 2025
Merged
[go_router] Fix requestFocus propagation to Navigator#9177auto-submit[bot] merged 5 commits intoflutter:mainfrom
auto-submit[bot] merged 5 commits intoflutter:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
chunhtai
approved these changes
Apr 29, 2025
Contributor
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, you also need to bump the pubspec.yaml to match change log version. otherwise, the ci will fail
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 9, 2025
flutter/packages@ab44c26...7814fab 2025-05-08 40433176+KevynSM@users.noreply.github.com [go_router] Fix requestFocus propagation to Navigator (flutter/packages#9177) 2025-05-08 65381000+raju8000@users.noreply.github.com [go_router_builder] Fixes an deprecated warning for using withNullability (flutter/packages#9158) 2025-05-08 engine-flutter-autoroll@skia.org Roll Flutter from b0f5c8c to 02d8c1a (19 revisions) (flutter/packages#9230) 2025-05-08 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Fix camera preview rotation for landscape oriented devices (flutter/packages#9097) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
Fixes [166972](flutter/flutter#166972) ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
Fixes [166972](flutter/flutter#166972) ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 166972
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3