[webview_flutter] Adds support to control whether to draw scrollbars by bparrishMines · Pull Request #9024 · flutter/packages

bparrishMines · 2025-04-08T02:19:36Z

Fixes flutter/flutter#62464
Updated version of #8174

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

…lbar

stuartmorgan-g

Looks good to split up with one addition; once that's added you can go ahead and split out the sub PRs.

stuartmorgan-g · 2025-04-17T17:32:41Z

packages/webview_flutter/webview_flutter/lib/src/webview_controller.dart

+  /// Whether the horizontal scrollbar should be drawn or not.
+  Future<void> setHorizontalScrollBarEnabled(bool enabled) {
+    return platform.setHorizontalScrollBarEnabled(enabled);
+  }


Can you also plumb through a Future<bool> supportsSetScrollBarsEnabled() method to the platform interface layer that clients can use to detect whether this is safe to call per https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#api-support-queries ? This won't make sense on all platforms, so we should expect that clients will need a support query indefinitely.

I'm also assuming you meant for this to return bool and not Future<bool> too?

Oops, I missed this, and didn't catch it in the platform interface review. It should have been Future<bool> in case there were a platform that could only determine this at runtime (e.g., based on the OS version).

Not a big deal though as that's an unlikely case to ever hit.

…lbar

…set whether to draw the scrollbar (#9249) Platform implementations of #9024 Part of flutter/flutter#62464 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…lbar

stuartmorgan-g

LGTM with one small change.

stuartmorgan-g · 2025-05-15T15:01:04Z

packages/webview_flutter/webview_flutter/lib/src/webview_controller.dart

+  /// should be drawn or not.
+  ///
+  /// See [setVerticalScrollBarEnabled] and [setHorizontalScrollBarEnabled].
+  bool supportsSetScrollBarsEnabled() {


Let's still make this Future<bool> at this layer so that in the unlikely event that we have to change things we can keep the user-facing API the same, and only add a duplicate method at the platform interface layer.

…lbar

…ollbars (flutter/packages#9024)

flutter/packages@58d4016...af0b9a9 2025-05-19 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds support to respond to recoverable SSL certificate errors (flutter/packages#9281) 2025-05-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20250107 to 20250517 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#9283) 2025-05-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20250107 to 20250517 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#9282) 2025-05-16 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds support to respond to recoverable SSL certificate errors (flutter/packages#9248) 2025-05-16 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to control whether to draw scrollbars (flutter/packages#9024) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…raw the scrollbar (flutter#9125) Part of flutter/flutter#62464 Platform interface portion for flutter#9024 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…set whether to draw the scrollbar (flutter#9249) Platform implementations of flutter#9024 Part of flutter/flutter#62464 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…lutter#9024) Fixes flutter/flutter#62464 Updated version of flutter#8174 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…set whether to draw the scrollbar (#9249) Platform implementations of flutter/packages#9024 Part of flutter/flutter#62464 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…raw the scrollbar (flutter#9125) Part of flutter/flutter#62464 Platform interface portion for flutter#9024 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…set whether to draw the scrollbar (flutter#9249) Platform implementations of flutter#9024 Part of flutter/flutter#62464 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…lutter#9024) Fixes flutter/flutter#62464 Updated version of flutter#8174 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

Jerry and others added 5 commits November 28, 2024 05:57

feat: Add scrollBarEnabled function

49f57ba

chore: Modify pubspec for test setup

1f1ad6f

test: Add dart test code

4217429

reset wkwebview

45abbc1

Merge branch 'main' of github.com:flutter/packages into webview_scrol…

afd7fc1

…lbar

github-actions bot added platform-android p: webview_flutter labels Apr 8, 2025

bparrishMines added 2 commits April 7, 2025 22:22

undo pubspec changes

d214e1a

proper dependency overrides

13421ca

github-actions bot added the platform-ios label Apr 8, 2025

bparrishMines added 6 commits April 7, 2025 22:28

update platform interface

05ab710

dart side of impl

c8387fe

java side impl

8475a1e

ios impl

7499acd

app facing updated

45f7a89

formatting

5778e9f

github-actions bot added the platform-macos label Apr 8, 2025

bparrishMines added the federated: all_changes PR that contains changes for all packages for a federated plugin change label Apr 8, 2025

bparrishMines changed the title ~~Webview scrollbar~~ [webview_flutter] Adds support to control whether to draw scrollbars Apr 8, 2025

suppress

61de0eb

bparrishMines requested a review from stuartmorgan-g April 8, 2025 03:44

bparrishMines marked this pull request as ready for review April 8, 2025 03:44

bparrishMines requested a review from cbracken as a code owner April 8, 2025 03:44

bparrishMines mentioned this pull request Apr 8, 2025

[webview_flutter] Add verticalScrollBarEnabled function #8174

Closed

11 tasks

add destroy

72f9fea

stuartmorgan-g reviewed Apr 17, 2025

View reviewed changes

bparrishMines added 4 commits April 18, 2025 15:57

Merge branch 'main' of github.com:flutter/packages into webview_scrol…

e6d0a5f

…lbar

update generated code

ac414de

regen mocks

1bdd7c6

add destory method

0f1461e

bparrishMines mentioned this pull request May 13, 2025

[webview_flutter_android][webview_flutter_wkwebview] Adds support to set whether to draw the scrollbar #9249

Merged

11 tasks

bparrishMines added 2 commits May 14, 2025 12:40

Merge branch 'main' of github.com:flutter/packages into webview_scrol…

cb123a5

…lbar

fix pubspecs and changelog

b667829

github-actions bot removed the platform-macos label May 14, 2025

bparrishMines added 2 commits May 14, 2025 12:47

fix pubspecs

518111c

actual fix

c88c097

github-actions bot removed the platform-ios label May 14, 2025

and one more file

0ecd78f

github-actions bot removed the platform-android label May 14, 2025

bparrishMines requested a review from stuartmorgan-g May 15, 2025 14:44

Merge branch 'main' of github.com:flutter/packages into webview_scrol…

2be1755

…lbar

stuartmorgan-g approved these changes May 15, 2025

View reviewed changes

bparrishMines added 2 commits May 15, 2025 12:41

change to future bool

181138b

Merge branch 'main' of github.com:flutter/packages into webview_scrol…

43ba081

…lbar

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025

auto-submit bot merged commit b6c74bd into flutter:main May 16, 2025
82 checks passed

bparrishMines deleted the webview_scrollbar branch May 16, 2025 19:55

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2025

b6c74bd [webview_flutter] Adds support to control whether to draw scr…

e3d2aa6

…ollbars (flutter/packages#9024)

engine-flutter-autoroll mentioned this pull request May 19, 2025

Roll Packages from 58d401608590 to 3a87d131e76d (4 revisions) flutter/flutter#169071

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2025

b6c74bd [webview_flutter] Adds support to control whether to draw scr…

8c1e2a3

…ollbars (flutter/packages#9024)

engine-flutter-autoroll mentioned this pull request May 19, 2025

Roll Packages from 58d401608590 to af0b9a941dd3 (5 revisions) flutter/flutter#169075

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[webview_flutter] Adds support to control whether to draw scrollbars#9024

[webview_flutter] Adds support to control whether to draw scrollbars#9024
auto-submit[bot] merged 37 commits intoflutter:mainfrom
bparrishMines:webview_scrollbar

bparrishMines commented Apr 8, 2025 •

edited

Loading

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Apr 17, 2025

Uh oh!

bparrishMines Apr 21, 2025 •

edited

Loading

Uh oh!

stuartmorgan-g May 14, 2025

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g May 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bparrishMines commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

bparrishMines Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g May 14, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bparrishMines commented Apr 8, 2025 •

edited

Loading

bparrishMines Apr 21, 2025 •

edited

Loading