Revert "[shared_preferences] update List<String> encode/decode"#8510
Closed
Revert "[shared_preferences] update List<String> encode/decode"#8510
Conversation
This reverts commit f7efc2b.
reidbaker
reviewed
Jan 27, 2025
| @@ -1,7 +1,3 @@ | |||
| ## 2.4.3 | |||
Contributor
There was a problem hiding this comment.
I forget our rules here but I thought we couldnt roll back this version if it was published which the existence of an OOB change implies happened.
Contributor
Author
There was a problem hiding this comment.
@stuartmorgan please advise. Should we publish a new version?
Collaborator
|
I just realized, I don't think we can revert this. It's been published and may have started converting real-world data to the new form. Updating to a reverted version would lose data. |
Collaborator
|
I'll look at the tests when I'm back at my desk to see if we can easily fix forward; hopefully the tests were just too specific to platform implementations. Otherwise I'll need to think about this more and discuss with @tarrinneal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8335.
This is causing
shared_preferences/shared_preferences/example/integration_test/shared_preferences_test.dart: shared_preferences_async Async throws TypeError when returned getStringList type is incorrectto fail with what looks like an OOB issue and is blocking the tree currently: